Repository navigation
Conversation
Signed-off-by: Amaury Pouly <amaury.pouly@opentitan.org>
Signed-off-by: Amaury Pouly <amaury.pouly@opentitan.org>
cfrantz
approved these changes
Nov 16, 2026
Comment on lines
+127
to
+134
| - name: Download OpenTitan devbundle | ||
| env: | ||
| DEVBUNDLE_RELEASE: devbundle-2026-10-21-1 | ||
| run: | | ||
| set -e | ||
| gh release download -R lowRISC/opentitan "$DEVBUNDLE_RELEASE" -O devbundle.tar.xz | ||
| mkdir devbundle | ||
| tar -xf devbundle.tar.xz -C devbundle |
Collaborator
There was a problem hiding this comment.
Should we migrate this to opentitan-signing-infra at some point?
Contributor
There was a problem hiding this comment.
Yes, but I think that's gated on using opentitan-signing-infra on earlgrey_1.0.0, which is in turn ideally gated on me merging back all of my SLH-DSA implementation and fixes, for which I am trying to backport to master at the same time so I can update things in sync and get parity across the branches. Unfortunately I have been running into a sequence of large PRs that I needed to backport to master first, but I am hoping I am mostly through that now and can focus on the backports, so we can resolve this situation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a CI flow which automatically test the pre-sign/post-sign release flow. The setup is a bit involved so I am trying to explain how it works below. This PR should also be reviewed with the content of
ot-sku-testingrepository: https://github.com/lowRISC/ot-sku-testinglowRISC/ot-skurepo).github/workflows/test-release-ci.ymlflow runs and uses the cross-ci mechanism to trigger ahttps://github.com/lowRISC/ot-sku-testing/blob/main/.github/workflows/trigger-test-release.ymlin theot-sku-testingrepository. This repository is technically a fork ofot-sku(for reasons noted below) but it is actually just a skeleton repo with the minimal yaml files to support the testing working.trigger-test-release.ymlin theot-sku-testingnow runs. The takes the SHA of the requested PR/branch and replicates it onot-sku-testing. Sinceot-sku-testingis a fork ofot-sku, they share the same underlying git storage so anot-skuSHA is also a validot-sku-testingSHA!test-release.ymlcoming from the PR/branch but runs it **on theot-sku-testingrepository.test-release.ymlfinally exercices the release flow. Since it runs in another repository, it can freely creates branch and releases. In the details, it:Example:
ot-sku: https://github.com/lowRISC/ot-sku/actions/runs/43525322046ot-sku-testing: https://github.com/lowRISC/ot-sku-testing/actions/runs/43525346596Final remarks: this works because currently the
ot00sku is signed with fake keys. When we change it to real keys, we obviously won't be able to sign in CI. The proposal would be to have a bazel setting so that we can swicthot-skuto fake keys for testing purposes.