[hsmtool] SLH-DSA key generation support - #30726
Merged
Merged
Conversation
cfrantz
reviewed
Jul 13, 2026
jwnrt
marked this pull request as draft
July 13, 2026 18:35
jwnrt
force-pushed
the
earlgrey-1.0.0-slh-dsa
branch
from
July 13, 2026 19:11
e57e58d to
6cdda3e
Compare
luismarques
reviewed
Jul 13, 2026
jwnrt
force-pushed
the
earlgrey-1.0.0-slh-dsa
branch
2 times, most recently
from
July 14, 2026 09:43
5d1b1b9 to
9a26d07
Compare
luismarques
reviewed
Jul 14, 2026
jwnrt
force-pushed
the
earlgrey-1.0.0-slh-dsa
branch
from
July 14, 2026 11:22
9a26d07 to
8bfe655
Compare
jwnrt
marked this pull request as ready for review
July 14, 2026 11:22
luismarques
approved these changes
Jul 14, 2026
cfrantz
approved these changes
Jul 15, 2026
jwnrt
force-pushed
the
earlgrey-1.0.0-slh-dsa
branch
from
July 15, 2026 12:41
8bfe655 to
e5b4051
Compare
rswarbrick
removed their request for review
July 16, 2026 11:44
Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
Selected 0.0.3 over 0.1.0 to ensure compatability with `ecdsa`'s `signature` dependency. Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
The types of these variables implement `Display` so we don't need to call `to_string` on them. The next crate update triggers a warning about this so we can fix it now. Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
Version >= 0.11.0 is required for SlhDsa support. This is the latest version at time of committing. The `cryptoki-profile` patch has been upstreamed and can be removed. The cryptoki-vendor-defined-mechanism-type patch required updating, and the new version has been upstreamed. Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
jwnrt
force-pushed
the
earlgrey-1.0.0-slh-dsa
branch
2 times, most recently
from
July 21, 2026 13:13
8a87b0b to
fa4b793
Compare
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spx command tree is left alone for backwards compatibility.