fix(hooks): skip the pre-push suite on delete-only pushes - #231
Merged
Conversation
Deleting a remote branch is a push, and the hook ran the full ~3-minute gate for every deletion — cleaning 21 stale remote branches after the P-series triggered it per branch until the batch timed out. A deletion moves no code: git hands the hook local_ref="(delete)" with an all-zero local sha, so treat those lines like the tag-only case and short-circuit. Mixed pushes (a real ref + deletions) still run the suite, and an empty stdin (dry-run) still falls through, as before. Verified by feeding the hook synthetic stdin for all three scenarios.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Найдено при чистке веток: удаление remote-ветки — это тоже push, и хук гонял полный ~3-минутный гейт на каждое из 21 удалений, пока батч не упёрся в таймаут. Удаление не несёт кода (git передаёт
(delete)+ нулевой sha) — теперь такие строки скипаются как tag-only случай. Смешанный пуш (код + удаления) по-прежнему гоняет сьют; пустой stdin (dry-run) по-прежнему проваливается в проверки. Проверено синтетическим stdin на всех трёх сценариях.