ci: keep @types/node majors pinned to the Node runtime - #14
Merged
Conversation
@types/node majors track the Node release they describe, and the workflows pin Node to 24. Letting the types run ahead of the runtime would typecheck against APIs that are not actually there. npm majors already fall outside the batched group, so this would have surfaced as its own PR either way. The ignore rule stops it recurring every month and records why: the types follow the runtime, not the other way around. Moving to a newer Node means changing node-version in both workflows and bumping this deliberately. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Dependabot configuration to prevent @types/node major version upgrades from drifting ahead of the Node.js version pinned in CI/deploy workflows (Node 24), avoiding typechecking against APIs not available in the runtime.
Changes:
- Add a Dependabot ignore rule to block major updates for
@types/nodein the npm ecosystem. - Document the rationale inline to make future Node + types upgrades an explicit, deliberate step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@types/nodemajors track the Node release they describe, and both workflows pin Node to 24. Letting the types run ahead of the runtime means typechecking against APIs that are not actually there.#12 is this exact case, opened by Dependabot within hours of #11 landing:
@types/node24 → 26.1.1, against a runtime that is still 24. This rule stops it recurring.Minor and patch updates still flow, so 24.12 → 24.13 arrives as before.
Why a rule rather than just closing the PR
npm majors already fall outside the batched group, so this would have surfaced as its own PR either way. The rule does two things beyond that: it stops the same PR reappearing every month, and it records why — the types follow the runtime, not the other way around.
Moving to a newer Node is then a deliberate two-step: change
node-versionin both workflows, and bump@types/nodeto match.Note
Worth closing #12 once this lands. #13 (typescript 6 → 7) is a genuine major worth its own look — this rule does not touch it.
🤖 Generated with Claude Code