Skip to content

feat(app): confirm requester adoption from accepted reports - #5890

Open
loopx-agent wants to merge 5 commits into
mainfrom
codex/l1-acceptance-journey-20261007
Open

loopx-agent wants to merge 5 commits into
mainfrom
codex/l1-acceptance-journey-20261007

Conversation

@loopx-agent

@loopx-agent loopx-agent commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

An App report could display requester adoption but offered no way to record the decision. The original conversation and Team execution report now let a user find an accepted downstream result using the displayed version, read it, and explicitly confirm adoption.

Before: leave the report and invoke the scoped adoption operation separately. After: discover, read and confirm in the existing report; the recorded result appears there. Discovery and reading never write. Confirmation starts no work and preserves a paused coordinator.

TypeScript owns conversation admission. The existing delegation owner rechecks grants, task acceptance, exact receiver inputs and output versions. Both entry points share the report reader and observation update. A lost acknowledgement reconciles the durable receipt without another write; an unresolved response retains the reviewed pair for explicit retry. Changed inputs withdraw adoption or reject confirmation. There is no new capability, provider, receipt schema or configuration switch.

中文:在原对话/团队执行报告中,查找使用当前版本的已验收后续结果,阅读后显式确认采用。同一 owner 校验授权与精确版本;确认不派工、不恢复协调员。回执丢失先读回,输入变化撤回采用;独立验收与采用保持分别呈现。

Validation at current head c11c54ce9bfca513e078664a2b6b9b5fc6eb92ec:

  • Fresh packaged interaction with the real isolated HTTP/SQLite adoption owner passed: keyboard confirmation, lost post-commit ACK with one write, changed-input withdrawal/restoration, paused-session preservation, zero extra dispatch, 390px and reduced motion. Surrounding workspace navigation and host work are synthetic; this is not native desktop or live-model qualification.
  • Four real HTTP/CLI/File/SQLite cases and six typed conversation rules passed. Control-plane types and packaged build/source verification passed. Initial typecheck could not find the root compiler; installing declared dependencies restored the check without source changes.
  • This head integrates main c464cf308c3c9bad5d1109a758d30dc3620bfde4, retaining both adoption and explicit revalidation APIs. Earlier checks at this head covered team evidence, frontend types, semantic checks and standard premerge. No code changed in this submission update.

Historical qualification at previous head d2d39ed4ddc6e083e3b05959dd05a7ecba650828:

  • Full TypeScript: 4,207 passed, 32 skipped. Isolated installed-wheel adoption and the real backend cases passed; those installed results are not inherited by the current head.
  • Required full Python: 18,791 passed, 46 failed, 252 skipped; 517 subtests passed. Independent pinned-base replay reproduced the failure sites. Attribution does not waive that failed check. Strict quality verification and managed premerge were held at that head.

Full Python and strict quality qualification have not been rerun at the current head. Independent exact-head review, required merge validation and maintainer merge authorization remain separate gates. The completed author proposal enters normal review; pending qualification or review is not a reason to retain Draft status.

This is a bounded App operation over already accepted work under Live Team Workspace L1. Independent-verifier receipts, real objection/revision/requester use, the complete first-use journey and installed native App adoption remain open. Do not infer independent acceptance from a reviewer name or an artifact hash.

The existing images below belong to the previous-head packaged qualification, with synthetic navigation and the real isolated adoption backend; they illustrate the interaction and do not prove current-head installation.

Desktop adoption readback

390px adoption readback

Reproduce the real-owner packaged journey:

uv sync --extra test
uv run --extra test python scripts/chat_bundle.py build --install
uv run --extra test node apps/presentation/dashboard/smoke/team-adoption-recovery-smoke.mjs

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
@mergify

mergify Bot commented Oct 10, 2026

Copy link
Copy Markdown

This pull request has merge conflicts with main and cannot be merged
until they are resolved. Please rebase or merge the base branch, @loopx-agent.

Choose the remote for the base repository, not an out-of-date fork.
For a fork clone, first inspect git remote -v; upstream must point
to https://github.com/loopx-project/loopx.git. If it is absent, add it
with git remote add upstream https://github.com/loopx-project/loopx.git.
Then run:

git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEAD

For a same-repository clone whose origin points to
https://github.com/loopx-project/loopx.git, use origin instead of
upstream for fetch/rebase. If you prefer merging the base, use
git merge <base-remote>/main and push normally.

Keep the DCO Signed-off-by trailer on every commit when you rebase.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Oct 10, 2026
Signed-off-by: song <liusongstep@gmail.com>
@mergify mergify Bot removed the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Oct 12, 2026
@loopx-agent
loopx-agent marked this pull request as ready for review October 12, 2026 20:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants