Repository navigation
Split mldoc library, CLI, JS and benchmark opam packages - #153
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing
mldoccurrently pulls benchmark, JavaScript and native CLI dependencies even for OCaml library consumers. Keep the existing library/API inmldocand give each tool its own package and installation target. Parser, exporter, CLI and benchmark implementation source is unchanged.All four packages directly require OCaml >= 4.14.0 and Dune >= 3.5.
mldocangstrom = dev,xmlm = dev,bigstringaf,ppx_deriving_yojson,uri,yojson.alcotest,qcheck,qcheck-alcotestare with-test;odocis with-doc.mldoc-climldoccommand: same-versionmldoc,cmdliner >= 1.1.0,lwt.mldoc-jsshare/mldoc-js/index.js: same-versionmldoc,js_of_ocaml >= 5.2.0, build-onlyjs_of_ocaml-ppx.mldoc-benchmldoc,core,core_bench,core_unix; unavailable on win32.Make defaults to the core library, with separate cli/js/bench targets and an explicit all target. npm publication builds only JS. CI checks installed packages separately for OCaml 4.14.x and 5.3.x. Existing library/export modules remain together.
Pin Angstrom to
3be9b966dc2bc9ccf9948d17a7b0df1cb526de15: the parser uses its exposed lookahead API and continuation behavior. Retain Xmlmeb469d536e98c98f2754c0ff8813c92b3a17fe9fto preserve OPML XML attribute newlines.Validation on macOS, OCaml 5.5.0 / Dune 3.23.1:
opam install --assume-builtconsumed already-verified package builds to avoid repeating them. In that version snapshot the core's default dependency closure falls from 114 to 19, excluding compiler packages and mldoc itself.Remote validation for head
4d623ba6128d199e1dd115d47903f3d16b463c18: CI completed successfully for all eight Linux jobs (OCaml 4.14.x / 5.3.x × four packages), including installed-artifact smoke checks and core regressions/docs. Format also passed. These versions were not run locally; Windows remains untested.