Skip to content

opam: gate core/core_bench/core_unix to non-Windows (bench-only deps) - #152

Merged
tiensonqin merged 1 commit into
masterfrom
devin/win32-opam-deps
Oct 1, 2026
Merged

tiensonqin merged 1 commit into
masterfrom
devin/win32-opam-deps

Conversation

@tiensonqin

Copy link
Copy Markdown
Collaborator

Summary

Gate core, core_bench, core_unix opam deps behind {os != "win32"}.

These only back bench/bench.exe, which opam's dune build -p mldoc @install never compiles (no public_name, not in @install/@runtest targets). Jane Street core* packages are unavailable on win32 (core_unix, core_extended, base_bigstring, ocaml_intrinsics all carry os != "win32" availability), so the unconditional dep made mldoc unsolvable when installed as a git-pinned dep on Windows — this blocks the logseq db-worker native daemon's Windows build.

Resolution on macOS/Linux is unchanged (os != "win32" is true → same dep set).

Link to Devin session: https://app.devin.ai/sessions/62087b2a7a364e878f71f03c7ca1302d
Open in Devin Desktop: https://app.devin.ai/desktop/session/62087b2a7a364e878f71f03c7ca1302d?variant=devin
Requested by: @tiensonqin

They back only bench/bench.exe, which opam's @install build never
compiles. Jane Street core* packages are unavailable on win32, so the
unconditional dep made the package unsolvable there.
@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tiensonqin
tiensonqin merged commit f11230c into master Oct 1, 2026
4 of 5 checks passed
@tiensonqin
tiensonqin deleted the devin/win32-opam-deps branch October 1, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants