Repository navigation
opam: gate core/core_bench/core_unix to non-Windows (bench-only deps) - #152
Merged
Merged
Conversation
They back only bench/bench.exe, which opam's @install build never compiles. Jane Street core* packages are unavailable on win32, so the unconditional dep made the package unsolvable there.
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate
core,core_bench,core_unixopam deps behind{os != "win32"}.These only back
bench/bench.exe, which opam'sdune build -p mldoc @installnever compiles (nopublic_name, not in@install/@runtesttargets). Jane Streetcore*packages are unavailable on win32 (core_unix,core_extended,base_bigstring,ocaml_intrinsicsall carryos != "win32"availability), so the unconditional dep mademldocunsolvable when installed as a git-pinned dep on Windows — this blocks the logseq db-worker native daemon's Windows build.Resolution on macOS/Linux is unchanged (
os != "win32"is true → same dep set).Link to Devin session: https://app.devin.ai/sessions/62087b2a7a364e878f71f03c7ca1302d
Open in Devin Desktop: https://app.devin.ai/desktop/session/62087b2a7a364e878f71f03c7ca1302d?variant=devin
Requested by: @tiensonqin