Repository navigation
fix(retained): rebuild kid lists after a wholesale invalidation - #234
Merged
Merged
Conversation
invalidate (journal truncation past the retained cursor, viewport/scale change, invalidate_paint) reset every fragment, but fresh fragments start with no kid list and nothing re-marked them, so the next frame painted childless roots: a blank window. In Logseq, opening the Keymap settings pane (~2.5k nodes in one batch, > the 8192-op journal) blanked the whole UI. Re-mark every node's kids on the next paint. Adds regression tests for journal overflow and explicit invalidate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lui_retained.invalidate(journal overflow past the retained cursor, viewport/scale change,invalidate_paint) reset all fragments, but nothing re-marked kid lists, so the next frame painted childless roots: an empty/blank window.Repro in Logseq native:
g s/ Settings → Keymap (one large batch > 8192 journal ops) blanked the entire UI.Fix: a
resyncflag set byinvalidate; the nextpaint_retainedre-marks every node viamark_rekids. Regression tests: journal overflow resync, invalidate rebuilds kids.