Repository navigation
fix(paint): paint labeled menu-item icon once - #233
Merged
Merged
Conversation
menu-item's box branch already paints the glyph in the fixed leading slot via control_icon_ops and text_placement_of reserves the slot in the label pad; labeled_content_ops painted a second side-slot copy, so every icon in a Linux/SDL overlay menu appeared twice. Adds a lui_paint regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu items with an
iconprop and a label painted the glyph twice on the native/SDL paint path: once in the fixed leading slot (control_icon_ops, box branch) and again as a labeled side-slot icon (labeled_content_ops). Visible in Logseqrefactor/luion Linux: every icon in the…page menu appears doubled.Fix:
labeled_content_opspaints only the label formenu-item(its pad already reserves the slot).Test:
lui_paintkinds/menu item single icon(fails with 2 images before the fix).