Skip to content

Resolve UUID page references before outline blocks and render them as plain text - #78

Merged
RCmerci merged 1 commit into
mainfrom
codex/page-first-uuid-references
Oct 15, 2026
Merged

RCmerci merged 1 commit into
mainfrom
codex/page-first-uuid-references

Conversation

@RCmerci

@RCmerci RCmerci commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

UUID references to journal and ordinary pages currently render the literal UUID: hydration reads an outline-block projection, then caches its miss as entity absence. Resolve unknown UUIDs through get_page first, falling back to the outline lookup only after explicit page absence. Only both missing results are negatively cached; errors, cancellation, invalidation and late completions preserve retry and epoch ownership.

Rename the narrow lookup consistently to V2_get_outline_block, V2_get_outline_block_summary and Database.get_outline_blocks, including direct callers, fixtures and tooling, without compatibility aliases. Expanded UUID references, including nested references, render as plain text with no reference navigation metadata. Explicit URL links and Timeline card navigation to its own Detail remain available.

Validation:

  • Public runtime suite: 132 tests passed, including 16 new page-first and cache-ownership cases reproduced RED before fixes. Worker application integration: 15 passed; application view: 86 passed. dune build -j 2 @runtest @all passed.
  • Real DB worker with transaction-generated synthetic databases: yesterday journal, ordinary page, outline block and missing UUID; cold/loaded/typed metadata, repeated and direct Detail, terminal failure/abandon/reset.
  • Actual iPhone 13 iOS 26.1 Simulator: 6 XCTest cases passed. Timeline and Detail resolve the date and text; plain-reference taps do not navigate; nested text, ordinary URLs, missing/cycles and existing layout verified. Screenshots retained in Library.
  • Simulator packaging reused the existing host ARM64 OCaml complete-object restamp route with Simulator crypto C and current production Swift; no physical-device ABI claim. No phone or real user graph access.

This change is independent of the Build-script PR and changes no Dune, lockfile, opam switch or pin configuration.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T03:27:56.882062Z f79f9d5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@RCmerci
RCmerci merged commit 4d6f13b into main Oct 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant