Repository navigation
Resolve UUID page references before outline blocks and render them as plain text - #78
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UUID references to journal and ordinary pages currently render the literal UUID: hydration reads an outline-block projection, then caches its miss as entity absence. Resolve unknown UUIDs through
get_pagefirst, falling back to the outline lookup only after explicit page absence. Only both missing results are negatively cached; errors, cancellation, invalidation and late completions preserve retry and epoch ownership.Rename the narrow lookup consistently to
V2_get_outline_block,V2_get_outline_block_summaryandDatabase.get_outline_blocks, including direct callers, fixtures and tooling, without compatibility aliases. Expanded UUID references, including nested references, render as plain text with no reference navigation metadata. Explicit URL links and Timeline card navigation to its own Detail remain available.Validation:
dune build -j 2 @runtest @allpassed.This change is independent of the Build-script PR and changes no Dune, lockfile, opam switch or pin configuration.