Repository navigation
Add reusable Apple build with explicit native provenance - #77
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee00a2aa07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Journal Apple builds currently reconstruct target, dependency, cache and signing checks across local scripts. The existing entry point also silently falls back to a stub and ignores signing failures. This change makes that entry point explicit and repeatable, with one shared Swift/package/icon/sign pipeline. AGENTS keeps a short entry link; detailed guidance lives in
.agents/skills/journal-build/SKILL.md.--native-objectcallers through isolated--probe-native-object; absent objects explicitly select link-only. Probe target/runtime/hash checks and distinct staged bundles carry no production provenance/ABI claim.Validation
24 build-boundary tests pass on Python 3.9 and 3.13, including changed/deleted historical archives, later builder-only commits, tampered object/source/C/header/evidence/receipt, live process locks and actual Simulator-vs-device SDK/Mach-O rejection.
Real icon compilation passes for macOS, Simulator and device.
Final script completed an actual iPhoneOS production package (1.0 / 1.5877.30): reused the immutable OCaml complete object, freshly compiled target C and Swift/LUI in a new cache namespace (Swift 25.65s), verified 55 iPhoneOS ARM64 Swift objects, mldoc/XMLm retention, icons/resources, signature/entitlements and input stability, from clean final head
293c05cc5a43b63e5bfbadd57a2414639cadfcb1. No phone installation or launch.Actual warm-start Swift source completed a full Simulator probe compile/link, icon packaging and strict adhoc signature verification at clean tested head
7a85f7d(Swift 25.85s; the later native-macOS GMP-only guard does not change the probe helper/source), using a caller-supplied target object. No installation, launch or runtime/ABI acceptance.Two Simulator link-only runs previously demonstrated cache reuse (Swift 24.92s to 0.55s, identical executable bytes). These are link/packaging checks only.
Independent exact-head review reproduced an early cache-lock release when a cancelled command leader exits before a SIGTERM-ignoring child. Fixed by terminating the remaining process group before unlock; the final review also caught untracked LUI Swift files bypassing the pin guard, which now rejects them before native import; the real fork/FIFO regression failed before and passes after. Independent pre-build journal-code-review passed; Final independent exact-head review confirmed the cancellation fix and the LUI untracked-source fix, with no remaining evidenced finding. Current decision and diff checks pass; the global decision check reports three unchanged historical documents with missing sections.
All four original GitHub review threads now contain specific fixes/evidence and are resolved. Independent exact-head reviews confirmed the additional local-pin ref/fixed-lock repair and final
293c05cGMP-copy guard; 24 tests pass on both Python versions. Final-head Journal CI completed successfully: icons, locked dependencies, all/native targets, full regression suite and logs passed.Limits
The explicitly selected host ARM64 OCaml/runtime restamp remains experimental compatibility, not a verified full iOS OCaml cross toolchain or ABI/runtime acceptance. This production packaging run did not recompile OCaml from scratch. Native macOS validation remains blocked locally by the pre-existing switch's missing mldoc, nonlocked XMLm and incomplete cached Git objects; build does not repair that environment implicitly.
A real macOS warm-start probe attempt passes the new object/CLI checks but stops at unchanged baseline
swift/JournalChrome.swift:378(listSectionSpacingis unavailable in macOS). This separate product limitation was not changed by this Build PR.