Solution: LP-0002 Private M-of-N Multisig#92
Open
Tranquil-Flow wants to merge 1 commit into
Open
Conversation
✅ Validation passedA reviewer will assess against the prize criteria. Automated check. See solution template and TERMS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LP-0002 resubmission after addressing reviewer feedback from PR #68.
Reviewer feedback addressed:
Deploy on real LEZ testnet — The wrapper program is now deployed and executed on the public LEZ testnet (https://testnet.lez.logos.co/). Deploy tx
82516880...in block 39547, execute txcb8bfd5...in block 39548, signed by funded testnet account6iArKUXxhUJqS7kCaPNhwMWt3ro71PDyBj7jwAyE2VQV. Evidence recorded insubmission/TESTNET_EVIDENCE.json.Document per-operation CU/gas —
submission/LEZ_COST_BENCHMARKS.jsonrecords the explicit CU-unavailable rationale (LEZ tooling does not expose stable per-tx CU counters) along with payload/account/receipt/block metrics.demo.sh end-to-end against live sequencer with RISC0_DEV_MODE=0 — The heavy-lane path (
scripts/demo-heavy-lane.sh) runs the real end-to-end flow against the LEZ testnet withRISC0_DEV_MODE=0proof artifacts.e2e-against-sequencer integration tests in CI — CI now includes
.github/workflows/ci.ymlalongside.gitlab-ci.yml, both green on the default branch.Additional improvements since PR #68:
.lgxpackage with alice/bob install evidencePublic repo: https://github.com/Tranquil-Flow/lp-0002-private-multisig
Thank you for the detailed feedback on #68. All points have been addressed.