refactor(website): load secrets from Astro server environment - #7055
Draft
theosanderson wants to merge 2 commits into
Draft
refactor(website): load secrets from Astro server environment#7055theosanderson wants to merge 2 commits into
theosanderson wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a stacked follow-up to #6994. It moves both secrets consumed by the website out of the processed
runtime_config.jsonfile and into Astro's typed server environment API.The transaction-cookie encryption key and existing Keycloak client secret are now declared as server-only secret fields in
astro.config.mjs. Kubernetes injects both values directly from their existing Secrets into the website container, and the website imports them fromastro:env/serverat runtime.The config processor remains in place because website organism configuration still uses it to materialize remote reference URLs, but it no longer receives or substitutes either website secret. Non-secret deployment configuration continues to use
runtime_config.json.Impact
.env.example.Verification
CI=1 npm run test -- --run— 71 files and 722 tests passed.npm run check-types— Astro and TypeScript reported no errors, warnings, or hints.npm run format— passed.npm run build— production server build completed successfully.helm lint kubernetes/loculus -f kubernetes/loculus/values.yaml— passed.runtime_config.json.Depends on #6994.
🚀 Preview: Add
previewlabel to enable