chore(deps-dev): bump to playwright with new firefox version - #7049
Conversation
… 3 updates Bumps the minorandpatch group with 3 updates in the /integration-tests directory: [@playwright/test](https://github.com/microsoft/playwright), [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) and [eslint](https://github.com/eslint/eslint). Updates `@playwright/test` from 1.61.1 to 1.62.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.61.1...v1.62.1) Updates `@types/node` from 26.1.1 to 26.1.2 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Updates `eslint` from 10.7.0 to 10.8.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v10.7.0...v10.8.0) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-version: 1.62.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minorandpatch - dependency-name: "@types/node" dependency-version: 26.1.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: minorandpatch - dependency-name: eslint dependency-version: 10.8.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: minorandpatch ... Signed-off-by: dependabot[bot] <support@github.com>
|
Claude finished @maverbiest's task in 1m 17s —— View job Claude's Review
SummaryThis is a small, well-scoped fix: bumps Observations
No blocking issues found. This looks safe to merge. |
corneliusroemer
left a comment
There was a problem hiding this comment.
Thanks for investigating and making a fix PR. Sounds reasonable to me, weird that we suddenly need it but so be it.
|
@corneliusroemer huh that's weird, is that from the failed run https://github.com/loculus-project/loculus/actions/runs/31168223702?pr=7007 ? Because when I looked at that trace the dot was right over the checkbox, also in "before":
I might just go ahead and merge this anyway since it seems to resolve the issue |


Clone of #7007 to see if Firefox integration test flakiness can be addressed.
Dependabot is trying to bump playwright from 1.61.1 to 1.62.1, which has Firefox version 153.0 (was 151.0 before: https://github.com/microsoft/playwright/releases).
The integration test for Firefox failed repeatedly and unpredictably on that branch on testing steps that create a new user through the Auth page, specifically when trying to check the 'I agree' check box (screenshots below). There is a playwright issue where people report clicking checkboxes in playwright as a source of flakiness (though not all exactly the same problem, see microsoft/playwright#13470)
This PR wraps the
this.page.getByLabel('I agree').check()in anexpect(...).toPass()so it retries. While this does seem to resolve flakiness, the underlying cause is still not clear to me. Especially because we have different checkboxes that arecheck()-ed without retrying in the integration tests where this issue doesn't arise (although those are not in the keycloakify page).Screenshots
Error message in CI logs of #7007
Playwright screenshots
Action:
The error logs:
Before:
After:
(the blue square that's added seems to be locator added by playwright, not the actual page,
__playwright_target__ marker)PR Checklist
🚀 Preview: Add
previewlabel to enable