Skip to content

chore(deps-dev): bump to playwright with new firefox version - #7049

Merged
maverbiest merged 5 commits into
mainfrom
fix-firefox-integration-test
Aug 10, 2026
Merged

chore(deps-dev): bump to playwright with new firefox version#7049
maverbiest merged 5 commits into
mainfrom
fix-firefox-integration-test

Conversation

@maverbiest

@maverbiest maverbiest commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Clone of #7007 to see if Firefox integration test flakiness can be addressed.

Dependabot is trying to bump playwright from 1.61.1 to 1.62.1, which has Firefox version 153.0 (was 151.0 before: https://github.com/microsoft/playwright/releases).

The integration test for Firefox failed repeatedly and unpredictably on that branch on testing steps that create a new user through the Auth page, specifically when trying to check the 'I agree' check box (screenshots below). There is a playwright issue where people report clicking checkboxes in playwright as a source of flakiness (though not all exactly the same problem, see microsoft/playwright#13470)

This PR wraps the this.page.getByLabel('I agree').check() in an expect(...).toPass() so it retries. While this does seem to resolve flakiness, the underlying cause is still not clear to me. Especially because we have different checkboxes that are check()-ed without retrying in the integration tests where this issue doesn't arise (although those are not in the keycloakify page).

Screenshots

Error message in CI logs of #7007

grafik

Playwright screenshots

Action:

grafik

The error logs:

Error: locator.check: Clicking the checkbox did not change its state
Call log:
  - waiting for getByLabel('I agree')
    - locator resolved to <input type="checkbox" id="termsAccepted" name="termsAccepted" aria-invalid="false" class="kcCheckboxInputClass"/>
  - attempting click action
    - waiting for element to be visible, enabled and stable
    - element is visible, enabled and stable
    - scrolling into view if needed
    - done scrolling
    - performing click action
    - click action done
    - waiting for scheduled navigations to finish
    - navigations have finished

Before:

grafik

After:

grafik

(the blue square that's added seems to be locator added by playwright, not the actual page, __playwright_target__ marker)

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by appropriate, automated tests.
  • Any manual testing that has been done is documented (i.e. what exactly was tested?)

🚀 Preview: Add preview label to enable

… 3 updates

Bumps the minorandpatch group with 3 updates in the /integration-tests directory: [@playwright/test](https://github.com/microsoft/playwright), [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) and [eslint](https://github.com/eslint/eslint).


Updates `@playwright/test` from 1.61.1 to 1.62.1
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.61.1...v1.62.1)

Updates `@types/node` from 26.1.1 to 26.1.2
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `eslint` from 10.7.0 to 10.8.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v10.7.0...v10.8.0)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-version: 1.62.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: minorandpatch
- dependency-name: "@types/node"
  dependency-version: 26.1.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minorandpatch
- dependency-name: eslint
  dependency-version: 10.8.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: minorandpatch
...

Signed-off-by: dependabot[bot] <support@github.com>
@claude

claude Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

This PR may be related to Firefox integration test issues: #5555, #5677, #4535

@maverbiest
maverbiest marked this pull request as ready for review August 7, 2026 11:23
@claude

claude Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Claude finished @maverbiest's task in 1m 17s —— View job


Claude's Review

  • Gather context (PR diff, files changed)
  • Review integration-tests/tests/pages/auth.page.ts change
  • Review package.json / package-lock.json bump
  • Post review feedback

Summary

This is a small, well-scoped fix: bumps @playwright/test (and related dev deps) from 1.61.1 → 1.62.1 in integration-tests/package.json/package-lock.json, and wraps the flaky I agree checkbox interaction in auth.page.ts with expect(...).toPass({ timeout: 10_000 }) to retry it against the new bundled Firefox (153.0).

Observations

No blocking issues found. This looks safe to merge.

@corneliusroemer corneliusroemer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating and making a fix PR. Sounds reasonable to me, weird that we suddenly need it but so be it.

@corneliusroemer

Copy link
Copy Markdown
Contributor

I looked at the trace again and I noticed that when selecting "before" the click location is slightly to the right of the checkbox. Maybe that's why the check goes nowhere - some people on the linked issue suggested the click was in the wrong place.

image

Doesn't matter though if your workaround works.

@maverbiest

Copy link
Copy Markdown
Contributor Author

@corneliusroemer huh that's weird, is that from the failed run https://github.com/loculus-project/loculus/actions/runs/31168223702?pr=7007 ? Because when I looked at that trace the dot was right over the checkbox, also in "before":

grafik

I might just go ahead and merge this anyway since it seems to resolve the issue

@maverbiest
maverbiest merged commit c08f8dd into main Aug 10, 2026
41 checks passed
@maverbiest
maverbiest deleted the fix-firefox-integration-test branch August 10, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants