feat(file-processing): prevent submission of interleaved fastq files - #7001
Draft
anna-parker wants to merge 6 commits into
Draft
feat(file-processing): prevent submission of interleaved fastq files#7001anna-parker wants to merge 6 commits into
anna-parker wants to merge 6 commits into
Conversation
…that downloads and validates input file format
Contributor
|
This PR may be related to: #6856 (MVP: Handle interleaved fastq submissions) — the diff explicitly rejects interleaved FASTQ files (both same-name and CASAVA-style mate-number formats) in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #6856 but is too inefficient atm to merge - we should use a bloomfilter like in the ena code base
I uploaded some mpox SRA fastq files and these lead preprocessing to fail with a timeout - 5min was not enough! Checking the logs it takes almost 3 whole minutes to download the S3 files... even when gzipped (80M)

Screenshot
PR Checklist
🚀 Preview: Add
previewlabel to enable