Skip to content

Fix IsSimpleOp for empty MultiPoint elements #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vera-rubin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix IsSimpleOp for empty MultiPoint elements #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/core/src/main/java/org/locationtech/jts/operation/valid/IsSimpleOp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ private boolean isSimpleMultiPoint(MultiPoint mp)
Set<Coordinate> points = new HashSet<Coordinate>();
for (int i = 0; i < mp.getNumGeometries(); i++) {
Point pt = (Point) mp.getGeometryN(i);
if (pt.isEmpty()) continue;
Coordinate p = pt.getCoordinate();
if (points.contains(p)) {
nonSimplePts.add(p);
Expand Down
14 changes: 14 additions & 0 deletions modules/core/src/test/java/org/locationtech/jts/operation/valid/IsSimpleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,20 @@ public void testMultiPointAll() {
BoundaryNodeRule.MOD2_BOUNDARY_RULE,
"MULTIPOINT((1 2), (1 4), (1 5))");
}

public void testMultiPointWithEmptyElements() {
String wkt = "MULTIPOINT (EMPTY, EMPTY, (1 2))";
Geometry g = read(wkt);
assertTrue(g.isSimple());
assertTrue(IsSimpleOp.isSimple(g));
checkIsSimple(wkt, BoundaryNodeRule.MOD2_BOUNDARY_RULE, true);
checkIsSimpleAll(wkt, BoundaryNodeRule.MOD2_BOUNDARY_RULE, "MULTIPOINT EMPTY");

String wktRepeated = "MULTIPOINT (EMPTY, EMPTY, (1 2), (1 2))";
checkIsSimple(wktRepeated, BoundaryNodeRule.MOD2_BOUNDARY_RULE, false, new Coordinate(1, 2));
checkIsSimpleAll(wktRepeated, BoundaryNodeRule.MOD2_BOUNDARY_RULE, "MULTIPOINT ((1 2))");
}

public void testGeometryCollectionAll() {
checkIsSimpleAll("GEOMETRYCOLLECTION(MULTILINESTRING ((10 20, 90 20), (10 30, 90 30), (50 40, 50 10)), " +
"MULTIPOINT((1 1), (1 2), (1 2), (1 3), (1 4), (1 4), (1 5), (1 5)))",
Expand Down