Repository navigation
Use hooks.post.install_steps for the cask quarantine step - #512
Merged
Merged
Conversation
joe4dev
force-pushed
the
devx-1124-cask-install-steps
branch
from
September 22, 2026 10:12
bc70c3a to
ba7d03d
Compare
joe4dev
force-pushed
the
devx-1124-guard-generated-homebrew-cask
branch
2 times, most recently
from
September 22, 2026 10:39
75fb741 to
dd3f443
Compare
1 of 2 tasks
joe4dev
force-pushed
the
devx-1124-cask-install-steps
branch
from
September 22, 2026 10:41
ba7d03d to
3170663
Compare
joe4dev
force-pushed
the
devx-1124-guard-generated-homebrew-cask
branch
from
September 22, 2026 10:46
dd3f443 to
be579b7
Compare
joe4dev
force-pushed
the
devx-1124-cask-install-steps
branch
from
September 22, 2026 10:47
3170663 to
476ffc4
Compare
joe4dev
force-pushed
the
devx-1124-guard-generated-homebrew-cask
branch
from
September 22, 2026 12:56
be579b7 to
607b035
Compare
joe4dev
force-pushed
the
devx-1124-cask-install-steps
branch
from
September 22, 2026 12:57
476ffc4 to
7e5504e
Compare
joe4dev
force-pushed
the
devx-1124-guard-generated-homebrew-cask
branch
from
September 22, 2026 14:02
607b035 to
260bb75
Compare
Base automatically changed from
devx-1124-guard-generated-homebrew-cask
to
main
September 23, 2026 14:59
joe4dev
force-pushed
the
devx-1124-cask-install-steps
branch
from
October 23, 2026 07:47
7e5504e to
6dd83e0
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
joe4dev
force-pushed
the
devx-1124-cask-install-steps
branch
from
October 23, 2026 09:55
6dd83e0 to
a5a5f8f
Compare
anisaoshafi
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#510 works around Homebrew's deprecated
postflightby writing the stanza throughcustom_block, at two costs:{{staged_path}}has to be escaped past GoReleaser's own template pass, and the stanza renders at the top of the cask, so every stanza after it tripsCask/StanzaOrder. #511 has to skip that cop to stay green.GoReleaser v2.19.0 (released 2026-10-22, via goreleaser/goreleaser#6873) adds the first-class option, which removes all three.
Solution
Replace
custom_blockwithhooks.post.install_steps, using GoReleaser's new.StagedPathfield in place of the escape. Behaviour is unchanged — the step still clears quarantine on the whole staged dir, as #477 made it.Also drops #511's
--except-cops=Cask/StanzaOrderand itsTODO(#512), and bumps the GoReleaser pin.Validation
Ran the released GoReleaser 2.19.0 against this config:
goreleaser checkpasses; 2.18.2 rejects it withfield install_steps not found in type config.HomebrewCaskHook, so an unbumped pin fails loudly rather than dropping the hookmake check-caskpasses:.StagedPathrenders to Homebrew's{{staged_path}}tokenmake lint-cask(brew style+brew audit) reports no offences with no exceptionEarlier, against #6873's pre-release build: the generated stanza was byte-identical to #510's, and Homebrew 7.0.4 loaded it as
Cask::Artifact::PostflightStepswith no deprecation warning.The install itself was verified on #510 for the identical stanza: quarantine cleared across all 43 staged files, and
lstk --versionruns.Docs
Nothing to document. No change to lstk's commands, flags, env vars or output, and no user-visible change to the cask's behaviour — this swaps the mechanism that generates an identical stanza.
Review
Human review advised: it touches the release pipeline. Both CI and the release job install GoReleaser from
.tool-versions, so they move to 2.19.0 together.Towards DEVX-1124
Closes DEVX-1130
🤖 Generated with Claude Code