DOCS (sept 8 launch hotfix): lstk migration guide - #873
Conversation
Deploying localstack-docs with
|
| Latest commit: |
0397999
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://16e01779.localstack-docs.pages.dev |
| Branch Preview URL: | https://docs-97-migration-guide-lstk.localstack-docs.pages.dev |
|
@remotesynth I've added it to the current subsection of |
remotesynth
left a comment
remotesynth
left a comment
There was a problem hiding this comment.
Made a few suggestions
Co-authored-by: Brian Rinaldi <brianrinaldi@fastmail.com>
|
allrighty @peter-smith-phd brian already left his review, so I incorporated his suggestions into your PR already right now, it looks like there's just one last feedback comment for you :) |
|
Given that I wrote this, I won't provide any addition review feedback. But, I did notice that it's not showing up in the preview pages. How would the users find this page? 
|
Replace the separate Homebrew/npm code blocks with a Tabs component, matching the pattern used elsewhere in the lstk docs, per review feedback.
|
Pushed Now checking Peter's concern about the page not showing in nav.... |
It's not showing up because you didn't update the astro config js @peter-smith-phd |
|
Ummm… just a reminder that I wrote the page in Notion, and somebody else converted it to the localstack-docs format 😛 |
Register the new lstk migration guide in the Developer Tools > Running LocalStack section, between the lstk CLI and MCP Server entries.
|
You asked why it wasn't showing up, I understood your question to be about not understanding how it works ;) @peter-smith-phd |
|
@remotesynth do you want to add anything? otherwise, can you approve the PR to remove merging blocker? This looks good to merge tmw if agreed. |
|
Heads up, pinging you here too @mmaureenliu in case you'd like to review now that you're back tmw. |
|
I definitely understand how it works, but I recommend you say "It's not showing up because the astro config js wasn't updated correctly" or "thanks for pointing that out, I'll fix it", rather than indicating that it was me that missed it in the first place. Just a different language choice. |
mmaureenliu
left a comment
mmaureenliu
left a comment
There was a problem hiding this comment.
A really well-written doc. Thanks @peter-smith-phd and all who contributed!
I made some very minor comments.
I also asked Jacque to take a look at the preview in case she has any feedbacks.
- Clarify that plain `lstk`/`lstk start` triggers the browser login automatically; `lstk login` is only needed to authenticate ahead of time or switch accounts. - Link each unsupported-feature name in the "Unsupported features" table to its docs page, and link the GitHub Action row to the setup-localstack repo, so readers can follow up for detail as the intro paragraph already promises.
|
Thanks @mmaureenliu — pushed
|
quetzalliwrites
changed the title
hotfix): lstk migration guide
This guide was written before the lstk docs were split into the nine-page running-localstack/lstk/ directory (merged in #898). Move it from the flat lstk-migration.mdx file into that directory as migration.mdx, and nest it in the sidebar's "lstk CLI" group instead of as a sibling entry, positioned right before FAQ & Troubleshooting. Drop the now-meaningless sidebar.order frontmatter field: this section uses an explicit sidebar array (order controlled by array position), not autogenerate, matching the other eight pages in the directory.
|
Update: merged latest
Didn't want this content-location mismatch to fall through the cracks now that the lstk docs have a real home. Pushed as |
4 participants
Peter authored this migration guide for lstk, it's ready for review.
Closes: https://linear.app/localstack/issue/DOC-97/docs-migration-guide-for-legacy-cli-new-lstk