add topologySpreadConstraints field to deployment - #154
Merged
carillan81 merged 1 commit intoSep 9, 2026
Merged
Conversation
simonrw
approved these changes
Sep 8, 2026
simonrw
left a comment
simonrw
left a comment
Contributor
There was a problem hiding this comment.
This looks like a fine change. Thanks for adding this.
Taking a step back, we have a few fields lifted directly from the pod spec - perhaps we should consider adding an extraPodOptions object type perhaps, and embedding that into the values.yaml file?
carillan81
deleted the
dpx-724-support-for-topologyspreadconstraint-in-helm-chart
branch
September 9, 2026 08:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There are some environments with specific configurations that require specific fields in the deployments to be present. Someone reported to need "topologySpreadConstraint" in their environment to be able to create deployments. As it's a trivial change, there is no reason to not adding the field to the available values.
Changes
We are adding:
Testing
create a values with topologySpreadConstraints field