Repository navigation
smite-scenarios: stop injecting negotiation state - #292
Merged
Merged
Conversation
morehouse
added this pull request to stack #289
October 16, 2026 03:37
morehouse
force-pushed
the
stop_injecting_negotiations
branch
from
October 16, 2026 21:06
7fc3334 to
85096cf
Compare
Have harness do the actual open_channel/accept_channel negotiation rather than injecting the negotiation state into the executor. The push and overflow tests keep their injected negotiations since AcceptChannelOracle would reject them before the expected errors could occur.
Do the actual open_channel/accept_channel negotiation rather than injecting the negotiation state into the executor.
morehouse
force-pushed
the
stop_injecting_negotiations
branch
from
October 16, 2026 21:59
85096cf to
1200c62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert all but two tests so that they actually do the
open_channel/accept_channelnegotiation rather than injecting the negotation state into the executor. This approach is easier to understand because the reader doesn't have to figure out what state was injected and how it affects the rest of the test. The test behavior is apparent from the executed program and queued target responses.The remaining two tests still use injected negotiations because otherwise the
AcceptChannelOracleprevents them from hitting the expected error. The next PR will remove those tests entirely.Depends on #291.