fix(dev): update local dev setup for ibex-client v3 OAuth2 auth#375
Open
forge0x wants to merge 1 commit into
Open
fix(dev): update local dev setup for ibex-client v3 OAuth2 auth#375forge0x wants to merge 1 commit into
forge0x wants to merge 1 commit into
Conversation
- Replace stale IBEX_EMAIL/IBEX_PASSWORD references with IBEX_CLIENT_ID/IBEX_CLIENT_SECRET - Update dev/setup.sh to prompt for OAuth2 client credentials - Update set-overrides.sh to write clientId/clientSecret instead of email/password - Update DEV.md docs to reflect new config format - Remove unused .env IBEX_* vars and update docker-compose env vars
There was a problem hiding this comment.
Pull request overview
This PR updates local development setup for the Ibex OAuth2 client-credentials migration, aligning dev scripts and docs with the app’s existing clientId/clientSecret config shape.
Changes:
- Replaces legacy Ibex email/password prompts and config generation with OAuth2 client credentials.
- Updates local config documentation and sample overrides.
- Updates docker compose and
.envIbex variable names for the price service/local environment.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
docker-compose.yml |
Passes IBEX_CLIENT_ID and IBEX_CLIENT_SECRET to the price service. |
dev/setup.sh |
Prompts for OAuth2 credentials and generates local Ibex overrides. |
dev/config/set-overrides.sh |
Updates interactive override prompts for clientId/clientSecret. |
DEV.md |
Documents the new Ibex local override format. |
.env |
Replaces old Ibex env placeholders with OAuth2 credential placeholders. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ```bash | ||
| source .env && source .env.local | ||
| ``` | ||
| Flash uses YAML config files. Ibex OAuth2 credentials go in local config overrides, not env vars. |
Comment on lines
+88
to
+89
| export IBEX_CLIENT_ID='${IBEX_CLIENT_ID}' | ||
| export IBEX_CLIENT_SECRET='${IBEX_CLIENT_SECRET}' |
| echo "Checking Ibex credentials..." | ||
|
|
||
| if [ -f .env.local ] && grep -q "IBEX_PASSWORD" .env.local 2>/dev/null; then | ||
| if [ -f .env.local ] && grep -q "IBEX_CLIENT_ID" .env.local 2>/dev/null; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ENG-38 Ibex auth migration replaced email/password login with OAuth2 client credentials (clientId + clientSecret). The dev setup scripts and docs still referenced the old auth method.
Changes:
IBEX_EMAIL/IBEX_PASSWORDprompts withIBEX_CLIENT_ID/IBEX_CLIENT_SECRETindev/setup.shdev/config/set-overrides.shto prompt forclientId/clientSecretinstead ofemail/passwordDEV.mddocs to document the new config formatIBEX_URL/IBEX_EMAIL/IBEX_PASSWORDenv vars in.envanddocker-compose.ymlMultiple devs can share the same sandbox clientId/clientSecret.