Fixes adding non-existant hdf5 target in codevelop build - #1647
Merged
Conversation
white238
requested review from
chapman39 and
ebchin
and
a lite review from Copilot
August 14, 2026 23:08
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy HDF5 “target/name” cache overrides from the codevelop third-party CMake setup to avoid incorrectly forcing HDF5 link inputs (notably hdf5_hl-static) during re-configures, and updates Axom submodule configuration options.
Changes:
- Deleted historical HDF5 target/variable cache overrides in MFEM configuration.
- Added
AXOM_ENABLE_TUTORIALS=OFFto match other Axom feature disables in codevelop/submodule builds. - Minor formatting alignment of existing Axom option settings.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
338
to
342
| # Prefix the "check" targets | ||
| set(MFEM_CUSTOM_TARGET_PREFIX "mfem_" CACHE STRING "") | ||
|
|
||
| # Tweaks needed after Spack converted to the HDF5 CMake build system | ||
| # NOTE: we check if an hdf5 target is namespaced or not, since some versions | ||
| # of hdf5 do not namespace their targets and others do | ||
| set(HDF5_TARGET_NAMES "" CACHE STRING "") | ||
| if(TARGET hdf5::hdf5-static) | ||
| list(APPEND HDF5_TARGET_NAMES hdf5::hdf5-static) | ||
| else() | ||
| list(APPEND HDF5_TARGET_NAMES hdf5-static) | ||
| endif() | ||
| if(TARGET hdf5::hdf5-shared) | ||
| list(APPEND HDF5_TARGET_NAMES hdf5::hdf5-shared) | ||
| else() | ||
| list(APPEND HDF5_TARGET_NAMES hdf5-shared) | ||
| endif() | ||
|
|
||
| if(TARGET hdf5::hdf5_hl-static) | ||
| set(HDF5_C_LIBRARY_hdf5_hl hdf5::hdf5_hl-static CACHE STRING "") | ||
| else() | ||
| set(HDF5_C_LIBRARY_hdf5_hl hdf5_hl-static CACHE STRING "") | ||
| endif() | ||
|
|
||
| set(HDF5_IMPORT_CONFIG "RELEASE" CACHE STRING "") | ||
|
|
||
| # Add missing include dir to var that MFEM uses | ||
| if (CALIPER_FOUND) |
Member
Author
|
I didn't check the turning off Axom tutorials myself but CI will verify that. I am in a hurry to help my parents with something. Feel free to merge. |
ebchin
approved these changes
Aug 14, 2026
tupek2
approved these changes
Aug 14, 2026
btalamini
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1644
This logic was needed a long time ago and was blindly adding targets that may or may not be there (they weren't in some cases). But good news, the fix is no longer needed as far as I can tell.