Fix stale test fixtures and normalize resource CSV output - #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix stale/incorrect test-fixture documentation and normalize resource CSV quoting
Corrects five
.answer.jsonfiles and several legacy.csv.expectedprose descriptions (tests 01, 02, 03, 04, 05, 07, 11, 14, 15, 16, 22) that disagreed with their authoritative.expected_output.csv— including swapped job roles, wrong node counts, and a false idle-period claim in test 22. These files are not exercised by any test, so the errors were previously undetected; they're purely human-facing explanations of expected scheduler behavior.Also quotes multi-value
running_jobsfields in 37expected_resources.csvfiles (30 comprehensive + all 7 scale) to produce structurally valid CSV — confirmed no test reads that column, so this doesn't change test behavior. Fixes a truthiness bug intest_easy_vs_conservative_correctness.shthat printed real0start times asNone.Independently verified: every corrected schedule re-derived by hand from the raw input traces and EASY-backfill logic, all 27
.answer.jsonfiles checked exhaustively against their authoritative CSVs (not just the 5 changed), all 37 resource-CSV changes diffed to confirm columns 1–3 are byte-identical before/after, and the full test suite re-run with zero regressions.