Skip to content

Make callback dispatch deterministic - #27

Merged
SuperdoerTrav merged 1 commit into
mainfrom
fix/callback-dispatch-contract
Sep 19, 2026
Merged

SuperdoerTrav merged 1 commit into
mainfrom
fix/callback-dispatch-contract

Conversation

@SuperdoerTrav

Copy link
Copy Markdown
Collaborator

Resolve supported callback signatures once and propagate callback TypeError values unchanged across environment, spacecraft, adaptive orbit, and leapfrog paths. Add focused contract tests. This is an API-contract review branch, separate from bug fixes.

Summary

Repository Policy Checklist

  • If any part of this change was produced with an automated agent or LLM assistance, AGENTS.md was followed and this PR states what was verified by running it.
  • Changes preserve the existing file layout (ssapy_toolkit/, tests/, demos/, docs/, scripts/, .github/).
  • Package-code changes include tests under tests/, or this PR only changes docs/CI/metadata.
  • New user-facing workflows include a runnable demo under demos/, or no demo is needed because:
  • No generated outputs, downloaded data, images, notebooks with embedded outputs, binary media, or large artifacts are committed.
  • Persistent data needed by this work is stored in SSAPy-Data or documented as an external input.

Validation

  • pytest tests
  • python -m ssapy_toolkit.run_all_demos --no-open when demos or user-facing workflows changed
  • python scripts/check_repository_policy.py
  • No existing test, tolerance, workflow, or policy check was weakened to make this pass.
  • Every number quoted in this PR came from a command I ran on this change.

Resolve supported callback signatures once and propagate callback TypeError values unchanged across environment, spacecraft, adaptive orbit, and leapfrog paths. Add focused contract tests. This is an API-contract review branch, separate from bug fixes.
@SuperdoerTrav
SuperdoerTrav force-pushed the fix/callback-dispatch-contract branch from 534d961 to c5424d3 Compare September 19, 2026 20:05
@SuperdoerTrav
SuperdoerTrav merged commit 262b43c into main Sep 19, 2026
10 checks passed
@SuperdoerTrav
SuperdoerTrav deleted the fix/callback-dispatch-contract branch September 19, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant