Skip to content

Define explicit thrust profile semantics - #23

Merged
SuperdoerTrav merged 1 commit into
mainfrom
design/profile-semantics
Sep 19, 2026
Merged

SuperdoerTrav merged 1 commit into
mainfrom
design/profile-semantics

Conversation

@SuperdoerTrav

Copy link
Copy Markdown
Collaborator

Separate samples from segments and make index/time bounds explicit, rejecting ambiguous profiles with focused API tests. This is a design/API review branch, not part of the bug-fix series.

Summary

Repository Policy Checklist

  • If any part of this change was produced with an automated agent or LLM assistance, AGENTS.md was followed and this PR states what was verified by running it.
  • Changes preserve the existing file layout (ssapy_toolkit/, tests/, demos/, docs/, scripts/, .github/).
  • Package-code changes include tests under tests/, or this PR only changes docs/CI/metadata.
  • New user-facing workflows include a runnable demo under demos/, or no demo is needed because:
  • No generated outputs, downloaded data, images, notebooks with embedded outputs, binary media, or large artifacts are committed.
  • Persistent data needed by this work is stored in SSAPy-Data or documented as an external input.

Validation

  • pytest tests
  • python -m ssapy_toolkit.run_all_demos --no-open when demos or user-facing workflows changed
  • python scripts/check_repository_policy.py
  • No existing test, tolerance, workflow, or policy check was weakened to make this pass.
  • Every number quoted in this PR came from a command I ran on this change.

Separate samples from segments and make index/time bounds explicit, rejecting ambiguous profiles with focused API tests. This is a design/API review branch, not part of the bug-fix series.
@SuperdoerTrav
SuperdoerTrav force-pushed the design/profile-semantics branch from 28a02e9 to a612e6f Compare September 19, 2026 18:55
@SuperdoerTrav
SuperdoerTrav merged commit 1c978f1 into main Sep 19, 2026
10 checks passed
@SuperdoerTrav
SuperdoerTrav deleted the design/profile-semantics branch September 19, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant