bugfix for per-sample UQ - #202
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v18.1.8
Click here for the full clang-format patch
diff --git a/src/AMSlib/ml/surrogate.cpp b/src/AMSlib/ml/surrogate.cpp
index 21babee..a1801e7 100644
--- a/src/AMSlib/ml/surrogate.cpp
+++ b/src/AMSlib/ml/surrogate.cpp
@@ -182 +182 @@ std::tuple<torch::Tensor, torch::Tensor> SurrogateModel::_evaluate(
-
+
@@ -188 +188,2 @@ std::tuple<torch::Tensor, torch::Tensor> SurrogateModel::_evaluate(
- "UQ model returned per-output uncertainty {}, reducing to per-sample by taking max",
+ "UQ model returned per-output uncertainty {}, reducing to "
+ "per-sample by taking max",
Have any feedback or feature suggestions? Share it here.
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Member
|
@ckhansen I have push a commit with the correct |
Collaborator
Author
|
@lpottier Thanks for committing those changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small bugfix for UQ. When I was running AMS it was appearing to give me per-sample-dimension uncertainty values or maybe just multiple dimension uncertainty values. This just takes the max value if multiple uncertainties are output.