Repository navigation
Integrate PR #7 macOS support with current main - #11
Merged
llm-learner merged 9 commits intoSep 26, 2026
Merged
Conversation
install_hooks.py merges headroom's SessionStart and UserPromptSubmit hooks into $CODEX_HOME/hooks.json without touching other hooks, backs up a changed file, is idempotent, and supports --dry-run and --uninstall. Hook commands use the installing Python (python3), shell-quoted, with no PowerShell. It refuses interpreters older than 3.10, can set HEADROOM_DISPLAY for SessionStart (--display), and can symlink the skill into ~/.agents/skills (--link-skill). install.sh finds Python 3.10+. The non-destructive merge/backup/uninstall design follows the installer from PR llm-learner#2 on the wenkesheng branch. Co-authored-by: cat0825 <97736187+cat0825@users.noreply.github.com>
- Tray: on macOS the pystray status item runs detached on Tk's main thread (AppKit requirement) and hides the Dock icon. - Desktop: POSIX flock single-instance lock, Aqua transparency, fonts, right-click and colored buttons; the card opens below the menu bar. - The WebView2 card stays Windows-only; elsewhere the Tk card is the default, and a missing Tk/pystray falls back to the web dashboard. - tkinter is imported lazily so Pythons without Tk still work. - Hook: detach display processes into a new session on POSIX. - headroom.py --codex-home honors CODEX_HOME like the hook/dashboard. - Node test defaults to python3 outside Windows.
Add platform tests (installer dry-run/merge/uninstall in a temporary HOME, hook command generation, detached launches, POSIX lock, menu bar logic) that run on any OS, and replace the manual macOS/Linux README steps with the installer and the menu bar display in both languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #7's macOS changes now conflict with upstream
mainafter the multi-agent updates. This PR integrates those changes with the current hook and scorer interfaces so the macOS support can be reviewed and merged here.现在呢？scores as four characters even when the app prepends a long browser-state block.Validation: 104 Python tests passed (7 platform/dependency skips); the dashboard JavaScript regression test passed. Supersedes #7.