ci: limit the workflow token to reading repository contents - #21
Merged
Merged
Conversation
The unit test job inherited whatever the repository default allowed. A workflow level contents: read default covers it; the docker job keeps its own block, so publishing still works. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
@j0sh sorry for the ping, but was not sure if you have automatic deployments behind this repo, otherwise would have just merged. |
j0sh
approved these changes
Sep 10, 2026
Collaborator
|
Yep there should be an automatic docker build after merge in this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves code-scanning alert #1 (actions/missing-workflow-permissions). The Unit tests job declared no permissions, so its GITHUB_TOKEN inherited whatever the repository default allowed. This adds a workflow-level contents: read default; the docker job keeps its own packages: write block, so image publishing is unaffected.