Repository navigation
Keep the e2e harness preview playing across processor changes - #147
Merged
Merged
Conversation
refreshPreview assigned a new MediaStream to the preview's srcObject on every harness change event, which restarts the element and shows black until the next frame. Mode switches, background swaps, blur radius changes and detach all flickered. The preview now keeps one stream and swaps its video track only when the track itself changes.
|
1egoman
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The e2e harness's local preview flickered on mode switches, background swaps, blur radius changes and detach. The cause was the harness, not the SDK.
refreshPreviewassigned a newMediaStreamto the preview'ssrcObjecton every change event, even when the track was unchanged. That restarts the<video>element, which shows the black container background until the next frame arrives.The preview now keeps one
MediaStreamfor its lifetime and swaps its video track only when the track itself changes, on attach and detach.Only the on-page preview changes. The probe reads the track directly, so no test measurement is affected.
Measured
Preview element events per action, in headless Chrome:
emptied waiting loadstart loadeddataemptied waiting loadstart loadeddataAfter each action the preview shows the expected picture: the raw checkerboard after detach, a blurrier background at radius 20 than at 10, and a flat image in virtual-background mode.
Typecheck and all 18 e2e tests pass locally.