Require exp when verifying webhook JWTs - #170
Merged
Merged
Conversation
java-jwt accepts a signed token with no exp unless presence is required. WebhookReceiver is the Kotlin verify path.
🦋 Changeset detectedLatest commit: 1b17fad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
erikhortsch
approved these changes
Aug 19, 2026
Contributor
Author
|
Thanks for the review. Pushed the RegisteredClaims.EXPIRES_AT swap. |
Merged
SashaMIT
added a commit
to SashaMIT/oss-contributions
that referenced
this pull request
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
WebhookReceiver.receiveverifies the webhook JWT withJWT.require(alg).withIssuer(apiKey)only. java-jwt 4.x treats a missingexpas valid (claimVal == nullpasses the expiry check) unlesswithClaimPresence("exp")is set, so a hand-rolled token with a valid HMAC and no expiry verifies forever.First-party
AccessToken.toJwtalways setsexp. This is the same gap livekit/protocol#1706 closed on the Go verifier, livekit/python-sdks#779 on Python, livekit/node-sdks#710 on Node, and livekit/server-sdk-ruby#97 on Ruby. This repo has noTokenVerifier;WebhookReceiveris the verify path.Fix
Require the
expclaim on verify.Threat-model: the attacker can mint or obtain an HS256 token that omits
exp. They do not control the verifier secret or clock. Signature verification still succeeds and the credential never ages out. That is permanent access from a forgotten expiry, not host or agent authority.Test plan
./gradlew test --tests io.livekit.server.AccessTokenTest --tests io.livekit.server.WebhookReceiverTest(5/5)expraisesMissingClaimExceptionwithClaimPresence("exp")and that case fails (token is accepted)WebhookReceiverTestso the new case is not AccessToken-onlyMade with Cursor