TEL-1026: Utility for extracting transfer error details from error- #999 - #808
Open
genseric-ghiro wants to merge 4 commits into
Open
TEL-1026: Utility for extracting transfer error details from error- #999#808genseric-ghiro wants to merge 4 commits into
genseric-ghiro wants to merge 4 commits into
Conversation
Surface sip_transfer_reason / sip_transfer_id from the error metadata, and wrap transfer failures that carry no SIP status (ringing timeout, terminated subscription) as SipCallError too.
…sfer-error-details
genseric-ghiro
marked this pull request as ready for review
September 11, 2026 20:58
genseric-ghiro
requested review from
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
September 11, 2026 20:58
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
xianshijing-lk
approved these changes
Sep 11, 2026
xianshijing-lk
left a comment
xianshijing-lk
left a comment
Contributor
There was a problem hiding this comment.
two questions or nits,
Lgtm assuming you will be addressing them
| parts.append(f"{code} {reason}" if reason else str(code)) | ||
| what = "SIP transfer failed" if transfer_reason is not None else "SIP call failed" | ||
| result = f"{what}: {', '.join(parts)} ({self.code})" | ||
| extra = {k: v for k, v in self.metadata.items() if k not in _SIP_META_KEYS} |
Contributor
There was a problem hiding this comment.
curiously, is there any specific reason that we want to filter out sip_transfer_id from the logs here ?
Is it intentional ?
| assert err.sip_transfer_id == "STR_abc" | ||
| # No SIP response was involved in this failure. | ||
| assert err.sip_status_code is None | ||
| assert "STR_RINGING_TIMEOUT" in str(err) |
Contributor
There was a problem hiding this comment.
curiously, should we also do
assert "STR_abc" in str(err)
In case "STR_abc" should be in the error str ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary