Remove redundant AsyncId checks from instruction callbacks#232
Open
MaxHeimbrock wants to merge 1 commit intomainfrom
Open
Remove redundant AsyncId checks from instruction callbacks#232MaxHeimbrock wants to merge 1 commit intomainfrom
MaxHeimbrock wants to merge 1 commit intomainfrom
Conversation
FfiClient.TryDispatchPendingCallback already matches callbacks by requestAsyncId via ConcurrentDictionary.TryRemove before invoking the callback. The per-instruction AsyncId guard was therefore dead code. Remove the stored _asyncId field and guard from all 12 custom instruction classes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FfiClient.TryDispatchPendingCallback()already matches callbacks byrequestAsyncIdviaConcurrentDictionary.TryRemovebefore invoking the callback, so the per-instructionif (e.AsyncId != _asyncId) return;guard was dead code._asyncIdfield, assignment, and guard from all 12 custom instruction classes acrossParticipant.cs,Room.cs,Track.cs, andDataStream.cs.asyncIdconstructor parameter is kept since it is still passed toRegisterPendingCallback.Test plan
🤖 Generated with Claude Code