Repository navigation
Conversation
Co-authored-by: omnigent <noreply@omnigent.ai>
Co-authored-by: omnigent <noreply@omnigent.ai>
Co-authored-by: omnigent <noreply@omnigent.ai>
…ted first SwiftFormat 0.64 sortImports places access-scoped imports first, so in Sources/LiveKit/Protocols/AudioRenderer.swift and Sources/LiveKit/Protocols/AudioCustomProcessingDelegate.swift `internal import LiveKitWebRTC` now precedes `@preconcurrency import AVFoundation`. LiveKitWebRTC re-exports AVFoundation, so the module is first imported without `@preconcurrency` and the later attribute no longer suppresses the AVAudioPCMBuffer Sendable capture errors. Carrying `@preconcurrency` on the re-exporting import restores the suppression regardless of order. Co-authored-by: omnigent <noreply@omnigent.ai>
…matting The macos-26 runner image ships SwiftFormat 0.63.1, and brew's index on the runner is stale, so `brew install swiftformat` reports 0.63.1 as already installed and up to date. The repo is formatted with 0.64.2, and the two versions disagree on indent and wrapArguments for trailing-comma argument lists. Download the pinned release asset and put it on PATH ahead of the preinstalled binary. Co-authored-by: omnigent <noreply@omnigent.ai>
The runner image already has both formulas installed, so `brew install` is a no-op and the lint job keeps the preinstalled SwiftFormat 0.63.1. `brew upgrade` moves both to the current formula version and exits 0 when they are already current. Co-authored-by: omnigent <noreply@omnigent.ai>
The runner image ships SwiftFormat 0.63.1 but no SwiftLint, and its formula index is stale because auto-update is off. `brew upgrade` alone fails with "swiftlint not installed", and `brew install` alone leaves the preinstalled SwiftFormat at 0.63.1. Refresh the index, install whichever formula is missing, then upgrade whichever is outdated. Co-authored-by: omnigent <noreply@omnigent.ai>
Co-authored-by: omnigent <noreply@omnigent.ai>
|
|
…wrongly removes
SwiftFormat 0.64.2 with only the redundantReturn rule rewrites
`for try await case let .data(frame) in socket { return frame }` to a
bare `frame` statement. The `try await` plus `case let` combination
makes it treat the loop body as an expression, while `for await x`,
`for try await x`, `for case let` and `for await case let` are left
alone. Applied, recv would drain every frame and always return nil.
Co-authored-by: omnigent <noreply@omnigent.ai>
pblazej
commented
Oct 26, 2026
| - name: Install SwiftLint | ||
| run: brew install swiftlint | ||
| - name: Install SwiftLint and SwiftFormat | ||
| run: brew update && brew install swiftformat swiftlint && brew upgrade swiftformat swiftlint |
Contributor
Author
There was a problem hiding this comment.
To avoid pinning (awkward in brew).
…imports In the sorted import order AVAudioPCMBuffer reaches these files through LiveKitWebRTC's re-export, so `@preconcurrency import AVFoundation` no longer covers it. The previous fix put `@preconcurrency` on the LiveKitWebRTC import, which would also downgrade Sendable diagnostics for every LKRTC type in these files. The explicit rebinding keeps full checking with no preconcurrency import. Co-authored-by: omnigent <noreply@omnigent.ai>
pblazej
marked this pull request as ready for review
October 26, 2026 11:58
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reformats the repo for SwiftFormat 0.64, rebinds the two AVAudioPCMBuffer captures as nonisolated(unsafe) so the new import order needs no @preconcurrency import, keeps the one return that SwiftFormat 0.64.2 wrongly removes, and upgrades SwiftLint and SwiftFormat through brew in the CI lint job so CI matches the repo formatting.