feat: add disableIceLite connect option - #2085
Conversation
🦋 Changeset detectedLatest commit: e83bbde The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
|
|
@subham2006 Hi! This pull request generally makes sense though it is worth mentioning that this flag doesn't seem to exist on any other sdks (I also don't know of any sdks that allow passing raw query parameters?). I'm going to reach out to the SFU team and make sure they don't have any concerns with adding this but unless they bring anything up I'll probably aim to get this merged early to mid next week! Also, prior to merging, would you be able to click the "CLA not signed yet" button and sign the CLA? Thanks! |
|
Correct, no SDK exposes this, fixed the description. CLA signed, thanks! |
3 participants
Adds a
disableIceLiteoption toRoomConnectOptionsthat setsConnectionSettings.disable_ice_liteon the join request (anddisable_ice_lite=1on the v0 path), so a client can ask a server runninguse_ice_lite: truefor a full ICE agent, which the server already honors per participant since livekit/livekit#2862 and which livekit/protocol#1151 carried into the join request proto. livekit-server readsdisable_ice_litefrom the signal URL query string and this SDK preserves caller query params on the/rtcURL, sowss://host?disable_ice_lite=1already works as an undocumented workaround; no SDK exposes it as an option. libwebrtc clients behind some NATs nominate noticeably slower against a lite remote, so a browser or React Native app had no way to opt out.