Skip to content

feat: Allow applying new constraints to a screen share #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dadadah wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Allow applying new constraints to a screen share #2063

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dde6f83
feat: Allow applying new constraints to a screen share
Dadadah Aug 23, 2026
e4f52b7
fix: Don't silently drop contentHint and do encoding set outside lock
Dadadah Aug 23, 2026
ccbcbe9
fix: Apply new encoding to a screenshare even if dimensions don't change
Dadadah Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 42 additions & 5 deletions src/room/track/LocalVideoTrack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,16 @@ import type { LoggerOptions } from '../types';
import { isFireFox, isMobile, isSVCCodec, isWeb } from '../utils';
import LocalTrack from './LocalTrack';
import { Track, VideoQuality } from './Track';
import type { TrackPublishOptions, VideoCaptureOptions, VideoCodec } from './options';
import type {
ScreenShareCaptureOptions,
TrackPublishOptions,
VideoCaptureOptions,
VideoCodec,
VideoEncoding,
} from './options';
import { isBackupVideoCodec } from './options';
import type { TrackProcessor } from './processor/types';
import { constraintsForOptions } from './utils';
import { constraintsForOptions, screenCaptureToDisplayMediaStreamOptions } from './utils';

export class SimulcastTrackInfo {
codec: VideoCodec;
Expand Down Expand Up @@ -285,8 +291,38 @@ export default class LocalVideoTrack extends LocalTrack<Track.Kind.Video> {
await this.onSenderTrackSwapped();
}

protected override async onSenderTrackSwapped(): Promise<void> {
await this.refreshSenderEncodings();
async applyScreenShareConstraints(
constraints: Pick<ScreenShareCaptureOptions, 'resolution' | 'contentHint'>,
videoEncoding?: VideoEncoding,
): Promise<void> {
// Only valid for screen shares
if (this.source !== Track.Source.ScreenShare) {
return;
}

const mediaTrackConstraints = screenCaptureToDisplayMediaStreamOptions(constraints);

if (videoEncoding && this.publishOptions) {
this.publishOptions.screenShareEncoding = videoEncoding;
}

const unlock = await this.trackChangeLock.lock();
try {
if (typeof mediaTrackConstraints.video === 'object') {
await this.mediaStreamTrack.applyConstraints(mediaTrackConstraints.video);
}
if (constraints.contentHint) this.mediaStreamTrack.contentHint = constraints.contentHint;
Comment thread
Dadadah marked this conversation as resolved.
} finally {
unlock();
}

// Since resolution or encoding might be different, recompute the sender's encoding
// parameters.
await this.onSenderTrackSwapped(true);
}

protected override async onSenderTrackSwapped(ignoreDims = false): Promise<void> {
await this.refreshSenderEncodings(ignoreDims);
}

/**
Expand All @@ -295,7 +331,7 @@ export default class LocalVideoTrack extends LocalTrack<Track.Kind.Video> {
* if the track hasn't been published yet or if the track is in performance-optimized
* mode (which manages its own encodings).
*/
private async refreshSenderEncodings() {
private async refreshSenderEncodings(ignoreDims = false) {
if (!this.sender || !this.publishOptions || this.optimizeForPerformance) {
return;
}
Expand All @@ -313,6 +349,7 @@ export default class LocalVideoTrack extends LocalTrack<Track.Kind.Video> {
}

if (
!ignoreDims &&
this.lastEncodedDimensions &&
this.lastEncodedDimensions.width === dims.width &&
this.lastEncodedDimensions.height === dims.height
Expand Down
Loading