Use the same bundle for CI runs as releases - #242
Merged
Conversation
alan-george-lk
marked this pull request as ready for review
August 20, 2026 22:27
alan-george-lk
requested review from
stephen-derosa and
xianshijing-lk
as code owners
August 20, 2026 22:27
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alan-george-lk
commented
Aug 21, 2026
| } | ||
| if ($failed) { exit 1 } else { exit 0 } | ||
|
|
||
| - name: Verify SDK bundle |
Collaborator
Author
There was a problem hiding this comment.
This might be overkill, open to removing
stephen-derosa
approved these changes
Aug 24, 2026
stephen-derosa
left a comment
stephen-derosa
left a comment
Collaborator
There was a problem hiding this comment.
LGTM nice consolidation
| ```bash | ||
| ./build.sh release --bundle --prefix sdk-out/livekit-sdk | ||
| ``` | ||
|
|
Collaborator
There was a problem hiding this comment.
maybe add "linux/mac:" before the bash example and a "windows:" before the powershell example since it is possible to run poweshell on linux
Collaborator
Author
There was a problem hiding this comment.
Good call, added
…ature-unified-ci-builds Co-authored-by: Cursor <cursoragent@cursor.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context: SDK artifacts attached to CI runs diverged from official release artifacts. CI artifacts included intermediate static library objects, and were missing CMake files. This was reported by a user here in #212.
Therefore this PR changes the following:
build.cmd --bundle --prefixsupport and switched the Windows release job to use itTesting
Pulled CI-based run and compared folder/file contents to latest release packages across platforms.