fix: empty transcript blocks commit_user_turn until timeout#5429
Merged
Conversation
When using manual turn detection, commit_user_turn waits for _final_transcript_received to be set. If the STT returns a final transcript with empty text (e.g. silence), the event was never set because the empty check returned early, causing commit_user_turn to block until transcript_timeout. Move _final_transcript_received.set() before the empty transcript guard so the wait is unblocked regardless of transcript content.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
davidzhao
approved these changes
Apr 13, 2026
russellmartin-livekit
pushed a commit
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commit_user_turnwaits for_final_transcript_receivedto be set after flushing the STT buffer with silenceFINAL_TRANSCRIPTwith empty text (e.g. the user turn was silence),_on_stt_eventreturned early before setting the event, causingcommit_user_turnto block untiltranscript_timeout_final_transcript_received.set()before the empty transcript guard so the wait unblocks regardless of transcript content