Repository navigation
allow setting custom root element in flutter - #1065
Merged
Merged
Conversation
✅ Deploy Preview for livecodes ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Deploying livecodes with
|
| Latest commit: |
261e3dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://143d33a4.livecodes.pages.dev |
| Branch Preview URL: | https://flutter.livecodes.pages.dev |
|
Contributor
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Custom Flutter root element —
lang-dart-runtime.tsnow resolves a container for the Flutter engine (#livecodes-appfrom the HTML tab when present, else an injected full-page<div>) and passes it toDartWasm.loadRuntime, and defers runtime loading to firstrunso the container resolves afterdocument.body/markup exist. @live-codes/dart-wasm0.7.0 —vendors.tsbumps the CDN base URL to the release whoseloadRuntimeacceptscontainer.- Docs — new "Root Element" section plus an inline demo with a sized
#livecodes-appelement influtter.mdx.
I confirmed @live-codes/dart-wasm@0.7.0 is published and that loadRuntime supports container (Flutter embeds into the given element; with no container it defaults to document.body, which is why the previous eager load at head-parse time — when document.body is still null — fell back to the engine's own full-page host). The injected position: fixed; inset: 0 container reproduces that viewport-filling behavior, #livecodes-app matches the convention used by the react/vue/svelte/elm runtimes, and the lazy ready() is safe because the result page is a fresh document per run.
deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe Dart runtime now initializes on the first run. Flutter receives an existing ChangesFlutter runtime initialization
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant run
participant flutterContainer
participant DOM
participant loadRuntime
run->>flutterContainer: Select or create Flutter render container
flutterContainer->>DOM: Find #livecodes-app or append full-page div
run->>loadRuntime: Initialize runtime with Flutter container on first run
Merge Risk: ⚪ Minimal · up to The initialization retry limitation predates this change, and the custom Flutter render target is supported. No new merge-blocking issue is identified. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly describes the main change: allowing a custom root element for Flutter applications. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches 💡 1
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks 💡
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
livecodes-appelement. If one isn’t present, the app creates a full-page drawing area automatically.Documentation