Repository navigation
merge: cascade 8.4 into 8.5 - #309
Merged
Merged
Conversation
Apply one rule across src/Type and src/Reflection: a public method that returns a raw FFI\CData/CType or a generated struct stub view carries @internal (issue #194). - Add @internal to the unmarked escape hatches: StringEntry/ObjectEntry/ ReflectionValue/ReflectionClassConstant::getRawValue(), the ReflectionValue::getRaw*() getters, ClosureEntry::getRawFunction(), ResourceEntry::getRawData(), OpLine::getHandler(), ReflectionExtension::getGlobals(), ReflectionClass::newInstanceRaw() and PersistentObjectFactory::persistentClone(). - Merge stacked docblocks. PHP and PHPStan read only the last one, so the @internal on ReflectionClass::getRawValue(), FunctionLikeTrait::getEntryPointer(), ReflectionMethod::fromRawEntry() and ObjectEntry::setDynamicPropertiesPointer() was silently lost. Move the displaced docblocks of ReflectionMethod::fromClosureEntry(), dereferenceMapPointerSlot() and STORAGE_CE_FLAGS back to their owners. - Add RawEngineAccessorRule (tools/phpstan) so PHPStan enforces the rule. - Document the rule and the accessor naming convention in AGENTS.md. AbstractModule::getGlobals() is left as is: whether that consumer-facing override may return CData is decided in #192. Closes #194 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1ER6GtpZr8k2beJQqx
…#192 AbstractModule::getGlobals() exposes the module globals through this method, and that API contract is decided in #192. Drop its @internal marker again and exempt it in RawEngineAccessorRule with a TODO(#192). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1ER6GtpZr8k2beJQqx
chore(reflection): mark every raw-CData accessor @internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated cascade merge of
8.4into8.5(branch flow defined in.github/branch-flow.json).Resolve conflicts in favour of the newer engine structures where they touch
include/- regenerate headers on the target branch instead of merging them textually. See AGENTS.md.