Skip to content

chore(gen): regenerate 8.4 engine definitions for PHP 8.4.27 - #303

Merged
lisachenko merged 3 commits into
8.4from
chore/regenerate-8.4-headers
Nov 7, 2026
Merged

lisachenko merged 3 commits into
8.4from
chore/regenerate-8.4-headers

Conversation

@lisachenko

Copy link
Copy Markdown
Owner

What this changes

Brings the generated 8.4 engine definitions up to date with PHP 8.4.27. Every *headers up to date check fails on the 8.4 line right now (seen on #302), because this patch release added two engine fields:

  • zend_compiler_globals.interned_strings_fallible (_Bool). It sits at offset 443, in former padding, so ast stays at 448.
  • zend_executor_globals.delayed_oom (new zend_oom_info struct plus the zend_oom_state enum). It is appended at the end; EG grows from 1960 to 1984 bytes (2128 to 2152 on ZTS).

No existing offset moves, so this refreshes generated files only. Nothing under src/ changes.

How each target was regenerated, without hand-editing anything:

  • linux-x64-nts/zts, stubs/ and .phpstorm.meta.php: composer gen-headers (Docker, php:8.4 image, PHP 8.4.27). The generator's FFI validation passed for both targets, with 39 struct layouts matching the C compiler.
  • darwin-{x64,arm64}-{nts,zts} and windows-x64-{nts,zts}: the Generate darwin headers and Generate windows headers workflows, run via workflow_dispatch on this branch. They commit their output here.

Once this merges and cascades, #302 (and any other PR against 8.4) can pick it up.

Environment it was verified on

  • PHP version: PHP 8.4.27 (official php:8.4 Docker image, used by the generator)
  • Thread safety: NTS and ZTS
  • OS / architecture: Linux x64 (darwin and windows on their CI runners)
  • Debug build (--enable-debug)? no

Checklist

  • Targets the minimum affected version branch (8.4)
  • composer test passes on the matching PHP minor (left to CI; no PHP 8.4 runtime here)
  • composer phpstan (level max) and composer cs:check are green (left to CI)
  • Tests added or updated: n/a, generated files only
  • Nothing under include/, stubs/ or .phpstorm.meta.php was hand-edited; everything comes from the generator
  • Conventional Commits used for the commit messages

Generated by Claude Code

claude and others added 3 commits November 7, 2026 00:34
PHP 8.4.27 added two engine fields:
- zend_compiler_globals.interned_strings_fallible (_Bool, in the former
  padding at offset 443, so ast stays at 448)
- zend_executor_globals.delayed_oom (new zend_oom_info struct, appended at
  the end; EG grows 1960 -> 1984 bytes, 2128 -> 2152 on ZTS)

No existing offset moves. Regenerated with `composer gen-headers` (docker,
php:8.4); the darwin and windows targets follow from their workflows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FxhC1Ec16gRujMto2EbKdR

Copy link
Copy Markdown
Owner Author

CI needs a fresh run on the current head

The red Generated darwin/windows headers up to date checks ran on 04230ef, the linux-only commit, before the generator workflows finished. Both workflows have now committed:

  • 2aaa279 Generate darwin FFI engine definitions for PHP 8.4
  • b2f6531 Generate windows FFI engine definitions for PHP 8.4

All six darwin/windows layouts.json files change only by the same two additions as linux: interned_strings_fallible at 443, and delayed_oom appended at the end of EG. No other offset moves.

Those commits were pushed with GITHUB_TOKEN, which doesn't trigger workflows, so no CI has run on b2f6531 yet. A human push to the branch, or closing and reopening the PR, starts it.


Generated by Claude Code

@lisachenko
lisachenko marked this pull request as ready for review November 7, 2026 07:29
@lisachenko
lisachenko merged commit 59bf5bc into 8.4 Nov 7, 2026
21 checks passed
@lisachenko
lisachenko deleted the chore/regenerate-8.4-headers branch November 7, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants