Repository navigation
chore(gen): regenerate 8.4 engine definitions for PHP 8.4.27 - #303
Merged
Merged
Conversation
PHP 8.4.27 added two engine fields: - zend_compiler_globals.interned_strings_fallible (_Bool, in the former padding at offset 443, so ast stays at 448) - zend_executor_globals.delayed_oom (new zend_oom_info struct, appended at the end; EG grows 1960 -> 1984 bytes, 2128 -> 2152 on ZTS) No existing offset moves. Regenerated with `composer gen-headers` (docker, php:8.4); the darwin and windows targets follow from their workflows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1Ec16gRujMto2EbKdR
Owner
Author
|
CI needs a fresh run on the current head The red
All six darwin/windows Those commits were pushed with Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Brings the generated 8.4 engine definitions up to date with PHP 8.4.27. Every
*headers up to datecheck fails on the8.4line right now (seen on #302), because this patch release added two engine fields:zend_compiler_globals.interned_strings_fallible(_Bool). It sits at offset 443, in former padding, soaststays at 448.zend_executor_globals.delayed_oom(newzend_oom_infostruct plus thezend_oom_stateenum). It is appended at the end; EG grows from 1960 to 1984 bytes (2128 to 2152 on ZTS).No existing offset moves, so this refreshes generated files only. Nothing under
src/changes.How each target was regenerated, without hand-editing anything:
stubs/and.phpstorm.meta.php:composer gen-headers(Docker,php:8.4image, PHP 8.4.27). The generator's FFI validation passed for both targets, with 39 struct layouts matching the C compiler.workflow_dispatchon this branch. They commit their output here.Once this merges and cascades, #302 (and any other PR against
8.4) can pick it up.Environment it was verified on
PHP 8.4.27(officialphp:8.4Docker image, used by the generator)--enable-debug)? noChecklist
8.4)composer testpasses on the matching PHP minor (left to CI; no PHP 8.4 runtime here)composer phpstan(level max) andcomposer cs:checkare green (left to CI)include/,stubs/or.phpstorm.meta.phpwas hand-edited; everything comes from the generatorGenerated by Claude Code