You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(opcache): replace path-scoped PHPStan ignores with struct shapes #126
Follow-up to the OpCache binary-file API (#111, merged). Tech debt.
PayloadRelocator and ReflectionOpcacheFile are held to level max via path-scoped ignore entries in phpstan.dist.neon (property.nonObject, binaryOp.invalid, cast.int, argument.type) because their multi-hop FFI\CData reads ($zval->u1->v->type, $zval->value->str, …) resolve to mixed after the first hop. This is consistent with the repo's "FFI blast radius" stance but is looser than the rest of the codebase, which uses named PHPStan object shapes (ZendOpArrayShape, etc.) surfaced by typed accessors.
Scope: introduce named shapes (e.g. ZendPersistentScriptShape, ZendScriptShape, plus zval/hash/class-entry shapes as needed) and narrow at the read sites, then remove the per-file ignore blocks. Keep only the genuinely irreducible CData ignores. Purely internal; no behaviour change.
No chore label exists in this repo; flagging the nature here.
Activity
refactor(opcache): replace path-scoped PHPStan ignores with struct sh…
fix(opcache): resolve duplicate $script property from #122/#126 merge