nemo-places-sidebar: fetch free-space info asynchronously (#3764) - #3831
Open
leigh123linux wants to merge 1 commit into
Open
nemo-places-sidebar: fetch free-space info asynchronously (#3764)#3831leigh123linux wants to merge 1 commit into
leigh123linux wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free-space info for Home, File System, mounted volumes, and bookmarks
was fetched with a single blocking GIO call per row from
update_places() on the main thread. A gvfs mount that never answers
(e.g. an Android phone connected with "No data transfer") froze the
whole sidebar - and with it, every open Nemo window - indefinitely.
Rows are now added with no free-space info, and an async
g_file_query_filesystem_info_async() call fills it in later if the
backend answers before the row is gone. No thread or timeout is
needed: the async call never blocks regardless of whether or when
the mount responds. Bookmarks pointing into a mount are covered the
same way, since they were exposed to the same hang.