Skip to content

cs_themes: hide the simplified settings button when no styles are installed #13963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fantu wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −0
Open

cs_themes: hide the simplified settings button when no styles are installed #13963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions files/usr/share/cinnamon/cinnamon-settings/modules/cs_themes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ def on_module_selected(self):
self.active_style = None
self.active_mode_name = None
self.active_variant = None
self.simplified_button = None

# HiDPI support
for mode in ["mixed", "dark", "light"]:
Expand Down Expand Up @@ -261,6 +262,11 @@ def on_module_selected(self):
button.set_label(_("Simplified settings..."))
button.set_halign(Gtk.Align.END)
button.connect("clicked", self.on_simplified_button_clicked)
# no_show_all, or the show_all() done on the page would reveal the
# button again after update_simplified_button() hid it
button.set_no_show_all(True)
self.simplified_button = button
self.update_simplified_button()
page.add(button)

page = DownloadSpicesPage(self, 'theme', self.spices, self.window)
Expand Down Expand Up @@ -525,8 +531,14 @@ def reset_look_ui(self):
# Position style combo on "Custom"
self.style_combo.append_text(_("Custom"))
self.style_combo.set_active(len(self.styles.keys()))
self.update_simplified_button()
self.ui_ready = True

def update_simplified_button(self):
# With no styles installed the simplified page has nothing to offer
if self.simplified_button is not None:
self.simplified_button.set_visible(len(self.styles) > 0)

def on_customize_button_clicked(self, widget):
self.set_button_chooser(self.icon_chooser, self.settings.get_string("icon-theme"), 'icons', 'icons', ICON_SIZE)
self.set_button_chooser(self.cursor_chooser, self.settings.get_string("cursor-theme"), 'icons', 'cursors', 32)
Expand Down
Loading