fix: gitlab fixes

[joanagmaia]

Summary

• Add merge_request-review-approved as a recognized review activity type in the PR analysis Tinybird pipes
• Fixes pull_request_analysis_baseline_merge_MV.pipe and pull_request_analysis_initial_snapshot.pipe to include GitLab approval events alongside change-request reviews

Test plan

• Verify Tinybird pipe deployments pick up the updated SQL
• Confirm GitLab MR approval events are reflected in PR analysis metrics

🤖 Generated with Claude Code

---

Note

Medium Risk
Deferring webhook removal until after commit can leave orphaned GitLab hooks if the process fails post-commit, while Tinybird pipe changes affect production PR metrics once deployed.

Overview
GitLab integration teardown no longer calls GitLab’s API to delete webhooks while destroyAll holds an open DB transaction. Webhook tokens, project IDs, and hook IDs are collected during the transactional delete loop, the transaction commits, then removeGitlabWebhooks runs in parallel. That avoids idle connections during slow external HTTP and reduces connection-timeout risk on bulk integration removal.

PR analysis (Tinybird) now treats GitLab merge_request-review-approved like other review signals when computing first reviewed timestamps. pull_request_analysis_baseline_merge_MV and pull_request_analysis_initial_snapshot include that activity type alongside pull_request-reviewed and merge_request-review-changes-requested, so MR approval events can drive reviewedAt / related metrics where they were previously ignored.

^{Reviewed by Cursor Bugbot for commit e3ccff5. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

• feat: add user authentication (CM-123)
• feat: add user authentication (IN-123)

Projects:

• CM: Community Data Platform
• IN: Insights

Please add a Jira issue key to your PR title.

[Copilot]

Pull request overview

Updates PR analysis aggregation to properly count GitLab MR approval events as review activity in Tinybird, and adjusts GitLab webhook cleanup during integration deletion to avoid holding DB transactions open during external HTTP calls.

Changes:

• Add merge_request-review-approved to the “reviewed” event filters in pull_request_analysis_initial_snapshot.pipe.
• Include merge_request-review-approved alongside other review types when computing reviewedAt/reviewedUpdatedAt in pull_request_analysis_baseline_merge_MV.pipe.
• Defer GitLab webhook deletions until after the DB transaction commits in IntegrationService.destroyAll.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
services/libs/tinybird/pipes/pull_request_analysis_initial_snapshot.pipe	Treat GitLab MR approvals as review events for initial snapshot metrics.
services/libs/tinybird/pipes/pull_request_analysis_baseline_merge_MV.pipe	Ensure baseline-merge aggregation includes GitLab approval reviews in reviewed timestamps.
backend/src/services/integrationService.ts	Move GitLab webhook removals out of the transaction to avoid DB connection timeouts.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.