Skip to content

fix: use loose regex for IP and mask input#553

Merged
mhduiy merged 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0519-fix-issue-361211
May 19, 2026
Merged

fix: use loose regex for IP and mask input#553
mhduiy merged 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0519-fix-issue-361211

Conversation

@MyLeeJiEun
Copy link
Copy Markdown
Contributor

  1. Add loose edit-time regex (ipEditRegExp, maskEditRegExp) that only allows digits and dots
  2. Replace strict validators with loose ones on IP address, subnet mask, and gateway input fields
  3. Allow users to type incomplete IP/mask values during editing without being blocked by validation

Log: Use permissive input regex for IPv4 address and subnet mask fields

fix: 使用宽松正则校验IP和子网掩码输入

  1. 新增编辑时宽松正则(ipEditRegExp, maskEditRegExp),仅允许数字和点
  2. 将IP地址、子网掩码和网关输入框的校验器替换为宽松正则
  3. 允许用户在编辑过程中输入不完整的IP/掩码值,不被严格校验阻断

Log: IPv4地址和子网掩码输入框使用宽松正则校验
PMS: BUG-361211

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @MyLeeJiEun, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot
Copy link
Copy Markdown

Hi @MyLeeJiEun. Thanks for your PR. 😃

@deepin-ci-robot
Copy link
Copy Markdown

Hi @MyLeeJiEun. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1. Add loose edit-time regex (ipEditRegExp, maskEditRegExp) that
   only allows digits and dots
2. Replace strict validators with loose ones on IP address,
   subnet mask, and gateway input fields
3. Allow users to type incomplete IP/mask values during editing
   without being blocked by validation

Log: Use permissive input regex for IPv4 address and subnet mask fields

fix: 使用宽松正则校验IP和子网掩码输入

1. 新增编辑时宽松正则(ipEditRegExp, maskEditRegExp),仅允许数字和点
2. 将IP地址、子网掩码和网关输入框的校验器替换为宽松正则
3. 允许用户在编辑过程中输入不完整的IP/掩码值,不被严格校验阻断

Log: IPv4地址和子网掩码输入框使用宽松正则校验
PMS: BUG-361211
@MyLeeJiEun MyLeeJiEun force-pushed the fork-from-master-0519-fix-issue-361211 branch from b1bb57a to ef97fe0 Compare May 19, 2026 07:00
@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit bd8a32f into linuxdeepin:master May 19, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants