Perftest: add --report-min-bw to sample minimum bandwidth over X iterations#214
Open
antgun42 wants to merge 1 commit into
Open
Perftest: add --report-min-bw to sample minimum bandwidth over X iterations#214antgun42 wants to merge 1 commit into
antgun42 wants to merge 1 commit into
Conversation
Author
|
Example output from |
mrgolin
reviewed
Jun 18, 2023
Contributor
|
Thanks for your contribution! |
Contributor
|
@antgun42 , thanks for the contribution. |
…ations Bandwidth tests report average and peak bandwidth, so transient dips (congestion, throttling, marginal links) are hidden inside the average. Add --report-min-bw=<iterations>, which also reports the minimum bandwidth observed over rolling windows of <iterations> iterations. - New long option --report-min-bw=<iterations>; bandwidth tests only. - Only printed when explicitly requested: the report format is unchanged from upstream unless --report-min-bw is set (base vs *_MINBW format variants). When set, adds a "BW min" column and a "BW_min" field to --out_json. - report_min_bw_cycles is uint64 to avoid wrapping on very slow results; the value is exchanged between server and client with the other bw_report fields. - Man-page entry under perftest.1. Signed-off-by: Anton Gunnarsson <agunnarsson@coreweave.com>
Author
|
Rebased onto current upstream and squashed to a single commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample and report the minimum bandwidth measured over X iterations. This is useful to pinpoint intermittently unstable links that wouldn't be seen on the average bandwidth