Skip to content

DPS-46305: Add 2 new log types for VPN Gateway - #1071

Draft
bbanucha-akamai wants to merge 1 commit into
linode:mainfrom
bbanucha-akamai:feature/DPS-46305-add-two-new-log-types-for-vpn-gateway
Draft

bbanucha-akamai wants to merge 1 commit into
linode:mainfrom
bbanucha-akamai:feature/DPS-46305-add-two-new-log-types-for-vpn-gateway

Conversation

@bbanucha-akamai

Copy link
Copy Markdown

📝 Description

Adds support for VPN Gateway IPsec and BGP log streams (vpngw_ipsec_logs, vpngw_bgp_logs) with vpn_gateway_ids. Ensures VPN requests omit LKE-specific fields while preserving existing LKE behavior.

✔️ How to Test

Unit tests cover JSON serialization and creation, retrieval, updates, listing, and history for both VPN stream types.
Run from the repository root:
go test ./... ./test/unit

Copilot AI balanced review requested due to automatic review settings November 2, 2026 17:10
@bbanucha-akamai
bbanucha-akamai requested review from a team as code owners November 2, 2026 17:10
@bbanucha-akamai
bbanucha-akamai requested review from lgarber-akamai and psnoch-akamai and removed request for a team November 2, 2026 17:11
@bbanucha-akamai
bbanucha-akamai marked this pull request as draft November 2, 2026 17:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the VPN Gateway log stream changes.

No open issues 🎉

What changed in this PR

Adds VPN Gateway IPsec and BGP log stream support to the public Go client while preserving existing LKE serialization behavior.

Changes:

  • Adds two VPN log stream types and the VPNGatewayIDs field.
  • Omits LKE-specific fields from VPN details and rejects mixed VPN/LKE settings.
  • Adds a VPN fixture and unit tests covering serialization, creation, updates, retrieval, listing, and history.
File Description
test/​unit/​monitor_logs_test.go Tests serialization and client operations for both VPN stream types.
test/​unit/​fixtures/​monitor_log_stream_vpngw.json Provides a sample VPN Gateway log stream response.
monitor_log_streams.go Adds VPN stream types, gateway selection, and type-specific details serialization.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants