Repository navigation
DPS-46305: Add 2 new log types for VPN Gateway - #1071
Draft
bbanucha-akamai wants to merge 1 commit into
Draft
bbanucha-akamai wants to merge 1 commit into
bbanucha-akamai wants to merge 1 commit into
Conversation
bbanucha-akamai
requested review from
lgarber-akamai and
psnoch-akamai
and removed request for
a team
November 2, 2026 17:11
bbanucha-akamai
marked this pull request as draft
November 2, 2026 17:11
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the VPN Gateway log stream changes.
No open issues 🎉
What changed in this PR
Adds VPN Gateway IPsec and BGP log stream support to the public Go client while preserving existing LKE serialization behavior.
Changes:
- Adds two VPN log stream types and the
VPNGatewayIDsfield. - Omits LKE-specific fields from VPN details and rejects mixed VPN/LKE settings.
- Adds a VPN fixture and unit tests covering serialization, creation, updates, retrieval, listing, and history.
| File | Description |
|---|---|
test/unit/monitor_logs_test.go |
Tests serialization and client operations for both VPN stream types. |
test/unit/fixtures/monitor_log_stream_vpngw.json |
Provides a sample VPN Gateway log stream response. |
monitor_log_streams.go |
Adds VPN stream types, gateway selection, and type-specific details serialization. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds support for VPN Gateway IPsec and BGP log streams (
vpngw_ipsec_logs,vpngw_bgp_logs) withvpn_gateway_ids. Ensures VPN requests omit LKE-specific fields while preserving existing LKE behavior.✔️ How to Test
Unit tests cover JSON serialization and creation, retrieval, updates, listing, and history for both VPN stream types.
Run from the repository root:
go test ./... ./test/unit