Skip to content

ACLP: Remove content field from list alert channels response#675

Merged
yec-akamai merged 2 commits intolinode:devfrom
shkaruna:cleanup/list-channels-content
Apr 8, 2026
Merged

ACLP: Remove content field from list alert channels response#675
yec-akamai merged 2 commits intolinode:devfrom
shkaruna:cleanup/list-channels-content

Conversation

@shkaruna
Copy link
Copy Markdown
Contributor

@shkaruna shkaruna commented Mar 31, 2026

📝 Description

Remove content field from list alert channels response.
content field is replaced with details.
Ticket: DPS-41868

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?
Not applicable

How do I run the relevant unit/integration tests?

Prerequisites:
Clone the repository
Prepare environment (zsh / macOS)

Create and activate venv:
python3 -m venv .venv
source .venv/bin/activate

install deps
python -m pip install --upgrade pip

Install runtime dependencies:
pip3 install requests polling deprecated

Install dev/test extras
pip3 install -e '.[dev,test]'

test deps
pip3 install pytest mock httpretty pytest-rerunfailures

Unit test:

  1. Run all unit tests:
    python -m pytest test/unit -q

  2. Run Monitor alert channels unit tests:

    python -m pytest -q -s -v test/unit/objects/monitor_test.py::MonitorTest::test_alert_channels
    =============================================================== test session starts ================================================================
    platform linux -- Python 3.10.12, pytest-9.0.2, pluggy-1.6.0
    rootdir: /home/shkaruna/sdk/linode_api4-python
    configfile: pyproject.toml
    plugins: anyio-4.12.1, rerunfailures-16.1
    collected 1 item

test/unit/objects/monitor_test.py .

================================================================ 1 passed in 0.13s =================================================================

Integration test:
#if you have PAT token with write access only to Monitor and read for rest of the services for integration
export SKIP_E2E_FIREWALL=1 # optional: skip firewall to use fixture
export LINODE_TOKEN="YOUR_REAL_TOKEN" # required for integration
python -m pytest test/integration/models/monitor/test_monitor.py::test_integration_create_get_update_delete_alert_definition -q -s
.
1 passed in 12.18s

@shkaruna
Copy link
Copy Markdown
Contributor Author

@satkumar-akamai : Please review

@shkaruna shkaruna force-pushed the cleanup/list-channels-content branch from 2cf161b to 6f7cefb Compare April 2, 2026 10:03
Copy link
Copy Markdown

@satkumar-akamai satkumar-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shkaruna shkaruna marked this pull request as ready for review April 2, 2026 10:51
@shkaruna shkaruna requested review from a team as code owners April 2, 2026 10:51
@shkaruna shkaruna requested review from dawiddzhafarov and psnoch-akamai and removed request for a team April 2, 2026 10:51
Copy link
Copy Markdown
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating the doc

@yec-akamai yec-akamai requested review from a team and jriddle-linode and removed request for a team April 7, 2026 15:24
@shkaruna shkaruna force-pushed the cleanup/list-channels-content branch from 752e5f8 to 2e3c67b Compare April 8, 2026 17:32
@yec-akamai yec-akamai added community-contribution for contributions made by a non-DX author improvement for improvements in existing functionality in the changelog. labels Apr 8, 2026
@yec-akamai yec-akamai merged commit 02cd383 into linode:dev Apr 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution for contributions made by a non-DX author improvement for improvements in existing functionality in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants