updating review comment fixes

Author: mawasthy-lgtm

linode_api4/groups/monitor.py

@@ -347,33 +347,13 @@ def channel_create(
         email list) that can be associated with one or more alert definitions.
         Currently only ``email`` is supported as a ``channel_type``.
 
-        Example usage::
-
-            from linode_api4.objects.monitor import ChannelDetails, EmailDetails
-
-            client = LinodeClient(TOKEN)
-
-            new_channel = client.monitor.channel_create(
-                label="Email channel for api change",
-                channel_type="email",
-                details=ChannelDetails(
-                    email=EmailDetails(
-                        recipient_type="user",
-                        usernames=["username-test"],
-                    )
-                ),
-            )
-
-        API Documentation: https://techdocs.akamai.com/linode-api/reference/post-alert-channel
+        API Documentation: https://techdocs.akamai.com/linode-api/reference/post-notification-channel
 
         :param label: Human-readable name for the new alert channel.
         :type label: str
         :param channel_type: The type of notification channel (e.g. ``"email"``).
         :type channel_type: str
-        :param details: Notification-type-specific configuration. Use
-                        :class:`~linode_api4.objects.monitor.ChannelDetails` with
-                        a nested :class:`~linode_api4.objects.monitor.EmailDetails`
-                        for email channels.
+        :param details: Notification-type-specific configuration.
         :type details: ChannelDetails
 
         :returns: The newly created :class:`AlertChannel`.

linode_api4/objects/monitor.py

@@ -8,6 +8,7 @@
 __all__ = [
     "AggregateFunction",
     "AlertChannel",
+    "AlertChannelType",
     "AlertDefinition",
     "AlertDefinitionChannel",
     "AlertDefinitionEntity",
@@ -387,6 +388,15 @@ class AlertScope(StrEnum):
     account = "account"
 
 
+class AlertChannelType(StrEnum):
+    """
+    Type values for alert channels.
+    """
+
+    system = "system"
+    user = "user"
+
+
 @dataclass
 class AlertEntities(JSONObject):
     """
@@ -490,11 +500,11 @@ class AlertChannel(Base):
     """
     Represents an alert channel used to deliver notifications when alerts
     fire. Alert channels define a destination and configuration for
-    notifications (for example: email lists, webhooks, PagerDuty, Slack, etc.).
+    notifications (for example: email lists, webhooks, Slack, etc.).
 
     API Documentation:
-        List/Get: https://techdocs.akamai.com/linode-api/reference/get-alert-channels
-        Create:   https://techdocs.akamai.com/linode-api/reference/post-alert-channel
+        List/Get: https://techdocs.akamai.com/linode-api/reference/get-notification-channel
+        Create:   https://techdocs.akamai.com/linode-api/reference/post-notification-channel
 
     This class maps to the Monitor API's ``/monitor/alert-channels`` resource
     and is used by the SDK to list, load, create, and inspect channels.
@@ -505,7 +515,7 @@ class AlertChannel(Base):
     properties = {
         "id": Property(identifier=True),
         "label": Property(mutable=True),
-        "type": Property(),
+        "type": Property(AlertChannelType),
         "channel_type": Property(),
         "details": Property(mutable=True, json_object=ChannelDetails),
         "alerts": Property(mutable=False, json_object=AlertInfo),

test/integration/models/monitor/test_monitor.py

@@ -335,8 +335,10 @@ def test_integration_create_get_update_delete_alert_channel(test_linode_client):
         # Get valid users to use for the email alert channel
         users = list(client.account.users())
         if len(users) == 0:
-            pytest.skip("No account users available for creating alert channels")
-        
+            pytest.skip(
+                "No account users available for creating alert channels"
+            )
+
         # Use the first user, or first two if available
         usernames = [users[0].username]
         if len(users) > 1: