fixing test case to not hardcode usernames

Author: mawasthy-lgtm

test/integration/models/monitor/test_monitor.py

@@ -332,14 +332,24 @@ def test_integration_create_get_update_delete_alert_channel(test_linode_client):
     created_channel = None
 
     try:
+        # Get valid users to use for the email alert channel
+        users = list(client.account.users())
+        if len(users) == 0:
+            pytest.skip("No account users available for creating alert channels")
+        
+        # Use the first user, or first two if available
+        usernames = [users[0].username]
+        if len(users) > 1:
+            usernames.append(users[1].username)
+
         # Create an alert channel with email details
         created_channel = client.monitor.channel_create(
             label=label,
             channel_type="email",
             details=ChannelDetails(
                 email=EmailDetails(
                     recipient_type="user",
-                    usernames=["mawasthy_tenant02_admin"],
+                    usernames=usernames,
                 )
             ),
         )

test/unit/groups/monitor_api_test.py

@@ -200,7 +200,7 @@ def test_create_update_delete_alert_channel(self):
             "channel_type": "email",
             "details": {
                 "email": {
-                    "usernames": ["test_user"],
+                    "usernames": ["test_user1", "test_user2"],
                     "recipient_type": "user",
                 }
             },
@@ -211,8 +211,8 @@ def test_create_update_delete_alert_channel(self):
             },
             "created": "2024-01-01T00:00:00",
             "updated": "2024-01-01T00:00:00",
-            "created_by": "test_user",
-            "updated_by": "test_user",
+            "created_by": "test_user1",
+            "updated_by": "test_user1",
         }
 
         with self.mock_post(create_response) as mock_post:
@@ -222,7 +222,7 @@ def test_create_update_delete_alert_channel(self):
                 details=ChannelDetails(
                     email=EmailDetails(
                         recipient_type="user",
-                        usernames=["test_user"],
+                        usernames=["test_user1", "test_user2"],
                     )
                 ),
             )

test/unit/objects/monitor_test.py

@@ -2,6 +2,7 @@
 from test.unit.base import ClientBaseCase
 
 from linode_api4.objects import AlertChannel, MonitorDashboard, MonitorService
+from linode_api4.objects.monitor import ChannelDetails, EmailDetails
 
 
 class MonitorTest(ClientBaseCase):
@@ -175,39 +176,50 @@ def test_create_update_delete_channel(self):
         Test CRUD operations for AlertChannel: create, update, and delete.
         Verifies the full lifecycle of an alert channel object.
         """
+        create_url = "/monitor/alert-channels"
         channel_id = 999
-        url = f"/monitor/alert-channels/{channel_id}"
+        channel_url = f"{create_url}/{channel_id}"
 
-        # Create the channel
+        # CREATE: Create the channel via channel_create()
         create_response = {
             "id": channel_id,
             "label": "CRUD Test Channel",
             "type": "user",
             "channel_type": "email",
             "details": {
                 "email": {
-                    "usernames": ["crud_user"],
+                    "usernames": ["crud_user1", "crud_user2"],
                     "recipient_type": "user",
                 }
             },
             "alerts": {
-                "url": f"{url}/alerts",
+                "url": f"{channel_url}/alerts",
                 "type": "alerts-definitions",
                 "alert_count": 0,
             },
             "created": "2024-01-01T00:00:00",
             "updated": "2024-01-01T00:00:00",
-            "created_by": "crud_user",
-            "updated_by": "crud_user",
+            "created_by": "crud_user1",
+            "updated_by": "crud_user1",
         }
 
-        with self.mock_get(create_response) as m_get:
-            channel = self.client.load(AlertChannel, channel_id)
+        with self.mock_post(create_response) as m_post:
+            channel = self.client.monitor.channel_create(
+                label="CRUD Test Channel",
+                channel_type="email",
+                details=ChannelDetails(
+                    email=EmailDetails(
+                        recipient_type="user",
+                        usernames=["crud_user1", "crud_user2"],
+                    )
+                ),
+            )
+            self.assertEqual(m_post.call_url, create_url)
             self.assertIsInstance(channel, AlertChannel)
             self.assertEqual(channel.id, channel_id)
             self.assertEqual(channel.label, "CRUD Test Channel")
 
-        # Update the channel
+        # UPDATE: Update the channel label
         updated_response = create_response.copy()
         updated_response["label"] = "CRUD Test Channel Updated"
         updated_response["updated"] = "2024-01-02T00:00:00"
@@ -216,13 +228,13 @@ def test_create_update_delete_channel(self):
             channel.label = "CRUD Test Channel Updated"
             result = channel.save()
 
-            self.assertEqual(m_put.call_url, url)
+            self.assertEqual(m_put.call_url, channel_url)
             self.assertTrue(result)
             self.assertEqual(channel.label, "CRUD Test Channel Updated")
 
-        # Delete the channel
+        # DELETE: Delete the channel
         with self.mock_delete() as m_delete:
             result = channel.delete()
 
-            self.assertEqual(m_delete.call_url, url)
+            self.assertEqual(m_delete.call_url, channel_url)
             self.assertTrue(result)